From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
Date: Mon, 09 Jul 2012 11:42:15 +0900 [thread overview]
Message-ID: <4FFA4507.1050303@kmckk.co.jp> (raw)
In-Reply-To: <20120708195848.1A52E202D56@gemini.denx.de>
Dear Wolfgang Denk,
(07/09/2012 04:58 AM), Wolfgang Denk wrote:
> Dear Tetsuyuki Kobayashi,
>
> In message <4FE85B87.6090302@kmckk.co.jp> you wrote:
>> NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
>
> Your patch is OK per se, but please note that it is a mandatory
> requirement that CONFIG_SYS_HZ == 1000. So if you have any board
> where this is not the case, this board needs to be fixed, too.
Thank you for reviewing my patch.
I didn't know that it is a mandatory requirement that CONFIG_SYS_HZ == 1000.
I grep'ed for CONFIG_SYS_HZ in README and under doc/, but I could not find any description about it.
$ grep -r CONFIG_SYS_HZ README doc/*
doc/README.LED:(CONFIG_SYS_HZ / <N>) where <N> is the frequency of the blink. Typical values
And I couldn't find that what value should be return in ulong get_timer(ulong base);
I hope "how to implement system timer" documented.
Best regards,
Tetsuyuki Kobayashi
next prev parent reply other threads:[~2012-07-09 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 12:37 [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000 Tetsuyuki Kobayashi
2012-07-08 19:58 ` Wolfgang Denk
2012-07-09 2:42 ` Tetsuyuki Kobayashi [this message]
2012-07-10 18:24 ` Joe Hershberger
2012-09-28 15:50 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFA4507.1050303@kmckk.co.jp \
--to=koba@kmckk.co.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.