From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sha Zhengju Subject: Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting Date: Mon, 09 Jul 2012 11:36:11 +0800 Message-ID: <4FFA51AB.30203@gmail.com> References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881562-5900-1-git-send-email-handai.szj@taobao.com> <20120708145309.GC18272@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=cmxcr1/XQrsiCqAPl0NZWugosJv17JlUoSYdMM4mdlg=; b=Z9z4XQOUbE/33B/lLsKilcyjXIs6zDBuWr52bjs0BqLLHJwoDkKW7zEEmPq5NEtZPg CWjJudl3zyFc01wttxOZfAScyZqKYUKPwY4+fSF9Nh+NiA9YRMhhuepMlwq1M/s2SwTh kCPRiYm9D++BBFAHRsYnJFRwW6C5Tbw+CP7g1kf2ZNtd0mz1ddmTNmrfzhz8smIPReMr WcHo9NMTg2YdtytvSwzh5KSEGmTOR8FrgYse7E7YSpCewML/nEvwA1rk5s4xlZXkp8VL VGLffRe6saz4MPXX7wzh0maUP3Eg09JOiHp/ALiGOoFwCHBIgJvQg2abNdwmBcuJENyn opsg== In-Reply-To: <20120708145309.GC18272@localhost> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Fengguang Wu Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sha Zhengju On 07/08/2012 10:53 PM, Fengguang Wu wrote: >> @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) >> { >> struct address_space *mapping = page_mapping(page); >> int ret; >> + bool locked; >> + unsigned long flags; >> >> + mem_cgroup_begin_update_page_stat(page,&locked,&flags); >> if (mapping) { >> struct backing_dev_info *bdi = mapping->backing_dev_info; >> unsigned long flags; >> @@ -2272,6 +2282,8 @@ int test_set_page_writeback(struct page *page) >> } >> if (!ret) >> account_page_writeback(page); >> + >> + mem_cgroup_end_update_page_stat(page,&locked,&flags); >> return ret; >> >> } > Where is the MEM_CGROUP_STAT_FILE_WRITEBACK increased? > It's in account_page_writeback(). void account_page_writeback(struct page *page) { + mem_cgroup_inc_page_stat(page, MEM_CGROUP_STAT_FILE_WRITEBACK); inc_zone_page_state(page, NR_WRITEBACK); } There isn't a unified interface to dec/inc writeback accounting, so I just follow that. Maybe we can rework account_page_writeback() to also account dec in? Thanks, Sha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 0CC2E6B006C for ; Sun, 8 Jul 2012 23:36:16 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so22432019pbb.14 for ; Sun, 08 Jul 2012 20:36:16 -0700 (PDT) Message-ID: <4FFA51AB.30203@gmail.com> Date: Mon, 09 Jul 2012 11:36:11 +0800 From: Sha Zhengju MIME-Version: 1.0 Subject: Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881562-5900-1-git-send-email-handai.szj@taobao.com> <20120708145309.GC18272@localhost> In-Reply-To: <20120708145309.GC18272@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Fengguang Wu Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju On 07/08/2012 10:53 PM, Fengguang Wu wrote: >> @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) >> { >> struct address_space *mapping = page_mapping(page); >> int ret; >> + bool locked; >> + unsigned long flags; >> >> + mem_cgroup_begin_update_page_stat(page,&locked,&flags); >> if (mapping) { >> struct backing_dev_info *bdi = mapping->backing_dev_info; >> unsigned long flags; >> @@ -2272,6 +2282,8 @@ int test_set_page_writeback(struct page *page) >> } >> if (!ret) >> account_page_writeback(page); >> + >> + mem_cgroup_end_update_page_stat(page,&locked,&flags); >> return ret; >> >> } > Where is the MEM_CGROUP_STAT_FILE_WRITEBACK increased? > It's in account_page_writeback(). void account_page_writeback(struct page *page) { + mem_cgroup_inc_page_stat(page, MEM_CGROUP_STAT_FILE_WRITEBACK); inc_zone_page_state(page, NR_WRITEBACK); } There isn't a unified interface to dec/inc writeback accounting, so I just follow that. Maybe we can rework account_page_writeback() to also account dec in? Thanks, Sha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209Ab2GIDgS (ORCPT ); Sun, 8 Jul 2012 23:36:18 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:49443 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028Ab2GIDgQ (ORCPT ); Sun, 8 Jul 2012 23:36:16 -0400 Message-ID: <4FFA51AB.30203@gmail.com> Date: Mon, 09 Jul 2012 11:36:11 +0800 From: Sha Zhengju User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Fengguang Wu CC: linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju Subject: Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881562-5900-1-git-send-email-handai.szj@taobao.com> <20120708145309.GC18272@localhost> In-Reply-To: <20120708145309.GC18272@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2012 10:53 PM, Fengguang Wu wrote: >> @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) >> { >> struct address_space *mapping = page_mapping(page); >> int ret; >> + bool locked; >> + unsigned long flags; >> >> + mem_cgroup_begin_update_page_stat(page,&locked,&flags); >> if (mapping) { >> struct backing_dev_info *bdi = mapping->backing_dev_info; >> unsigned long flags; >> @@ -2272,6 +2282,8 @@ int test_set_page_writeback(struct page *page) >> } >> if (!ret) >> account_page_writeback(page); >> + >> + mem_cgroup_end_update_page_stat(page,&locked,&flags); >> return ret; >> >> } > Where is the MEM_CGROUP_STAT_FILE_WRITEBACK increased? > It's in account_page_writeback(). void account_page_writeback(struct page *page) { + mem_cgroup_inc_page_stat(page, MEM_CGROUP_STAT_FILE_WRITEBACK); inc_zone_page_state(page, NR_WRITEBACK); } There isn't a unified interface to dec/inc writeback accounting, so I just follow that. Maybe we can rework account_page_writeback() to also account dec in? Thanks, Sha