From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1So7um-0007cy-5l for qemu-devel@nongnu.org; Mon, 09 Jul 2012 02:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1So7uk-00030F-Hx for qemu-devel@nongnu.org; Mon, 09 Jul 2012 02:57:47 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:54933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1So7uk-000306-8g for qemu-devel@nongnu.org; Mon, 09 Jul 2012 02:57:46 -0400 Received: by pbbro12 with SMTP id ro12so20321694pbb.4 for ; Sun, 08 Jul 2012 23:57:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FFA80E2.4080707@redhat.com> Date: Mon, 09 Jul 2012 08:57:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Deep Debroy , qemu-devel@nongnu.org Il 07/07/2012 09:56, Blue Swirl ha scritto: > These don't seem useful. I think DMA accessors should also be used. This is a paravirtualized device model, so I think no (like virtio). I agree that this patch can be dropped and the functions inlined manually in pvscsi.c (patch 4). Paolo