From: Lars-Peter Clausen <lars@metafoo.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 6/6] iio: iio_buffer_register: Use correct channel when calculating masklength
Date: Mon, 09 Jul 2012 11:09:30 +0200 [thread overview]
Message-ID: <4FFA9FCA.6070309@metafoo.de> (raw)
In-Reply-To: <1341824452-28803-6-git-send-email-lars@metafoo.de>
On 07/09/2012 11:00 AM, Lars-Peter Clausen wrote:
> The channel set assigned to the iio device is not necessarily the same has the
> channel set passed to iio_buffer_register. So to avoid possible complications
> always work with the channel set pass to iio_buffer_register and ignore the
> channel set assigned to the iio device.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Oops, this one was not supposed to be in this series... please just ignore it.
> ---
> No changes since v1
> ---
> drivers/iio/industrialio-buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 6e00042..e33a9dc 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -292,7 +292,7 @@ int iio_buffer_register(struct iio_dev *indio_dev,
> if (channels[i].scan_index >
> (int)indio_dev->masklength - 1)
> indio_dev->masklength
> - = indio_dev->channels[i].scan_index + 1;
> + = channels[i].scan_index + 1;
>
> ret = iio_buffer_add_channel_sysfs(indio_dev,
> &channels[i]);
next prev parent reply other threads:[~2012-07-09 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 9:00 [PATCH v2 1/6] iio: Add callback to check whether a scan mask is valid Lars-Peter Clausen
2012-07-09 9:00 ` [PATCH v2 2/6] iio: Introduce iio_validate_scan_mask_onehot Lars-Peter Clausen
2012-07-09 9:00 ` [PATCH v2 3/6] staging:iio:ad7192: Use iio_validate_scan_mask_onehot Lars-Peter Clausen
2012-07-09 9:00 ` [PATCH v2 4/6] staging:iio:ad7793: " Lars-Peter Clausen
2012-07-09 9:00 ` [PATCH v2 5/6] staging:iio:ade7758: " Lars-Peter Clausen
2012-07-09 9:00 ` [PATCH v2 6/6] iio: iio_buffer_register: Use correct channel when calculating masklength Lars-Peter Clausen
2012-07-09 9:09 ` Lars-Peter Clausen [this message]
2012-07-09 17:30 ` [PATCH v2 1/6] iio: Add callback to check whether a scan mask is valid Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFA9FCA.6070309@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.