From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoDzH-0003az-Ec for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoDzF-0002E1-J9 for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:26:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39062 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoDzF-0002Dv-9O for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:26:49 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 2F834A0FF5 for ; Mon, 9 Jul 2012 15:26:48 +0200 (CEST) Message-ID: <4FFADC16.4080507@suse.de> Date: Mon, 09 Jul 2012 15:26:46 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1341835600-2620-1-git-send-email-agraf@suse.de> In-Reply-To: <1341835600-2620-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel qemu-devel Am 09.07.2012 14:06, schrieb Alexander Graf: > When just calling ./configure on my box, I always ran into the same iss= ue: >=20 > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, > from /usr/include/nss3/pk11pub.h:43, > from libcacard/vcard_emul_nss.c:21: > /usr/include/nss3/pkcs11n.h:365:26: error: "__GNUC_MINOR" is not define= d >=20 > This is a bug in nss3. But why didn't configure bail out of the feature > if it doesn't even compile? Because this really is just a warning, not = an > error. But configure builds its test program without -Werror, while we = do > build our sources with -Werror by default. >=20 > Force the check to also use -Werror. This fixes the default build for m= e again. >=20 > Signed-off-by: Alexander Graf > --- > configure | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >=20 > diff --git a/configure b/configure > index 9f071b7..d28a909 100755 > --- a/configure > +++ b/configure > @@ -2642,6 +2642,10 @@ EOF > smartcard_cflags=3D"-I\$(SRC_PATH)/libcacard" > libcacard_libs=3D"$($pkg_config --libs nss 2>/dev/null) $glib_= libs" > libcacard_cflags=3D"$($pkg_config --cflags nss 2>/dev/null) $g= lib_cflags" > + # nss < 3.13.3 has a nasty warning that can trigger compile fa= ilures > + # with -Werror. Unfortunately, we don't know if -Werror is goi= nt to "going" > + # be used here yet, so let's just assume it to be safe. Maybe you can just temporarily supply it to compile_prog below then? Andreas > + libcacard_cflags=3D"$libcacard_cflags -Werror" > if $pkg_config --atleast-version=3D3.12.8 nss >/dev/null 2>&1 = && \ > compile_prog "$smartcard_cflags $libcacard_cflags" "$libcaca= rd_libs"; then > smartcard_nss=3D"yes" >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg