From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoE1Y-0007zg-O0 for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:29:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoE1W-0002q7-Ui for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:29:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoE1W-0002py-Me for qemu-devel@nongnu.org; Mon, 09 Jul 2012 09:29:10 -0400 Message-ID: <4FFADCA3.7060101@redhat.com> Date: Mon, 09 Jul 2012 15:29:07 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1341835600-2620-1-git-send-email-agraf@suse.de> In-Reply-To: <1341835600-2620-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel qemu-devel On 07/09/12 14:06, Alexander Graf wrote: > When just calling ./configure on my box, I always ran into the same issue: > > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, > from /usr/include/nss3/pk11pub.h:43, > from libcacard/vcard_emul_nss.c:21: > /usr/include/nss3/pkcs11n.h:365:26: error: "__GNUC_MINOR" is not defined > > This is a bug in nss3. But why didn't configure bail out of the feature > if it doesn't even compile? Because this really is just a warning, not an > error. But configure builds its test program without -Werror, while we do > build our sources with -Werror by default. > > Force the check to also use -Werror. This fixes the default build for me again. Good idea, but shouldn't we do that (a) for all compile tests and (b) only with --enable-werror ? cheers, Gerd