From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT
Date: Mon, 09 Jul 2012 16:07:36 +0200 [thread overview]
Message-ID: <4FFAE5A8.4000308@suse.de> (raw)
In-Reply-To: <20120709140429.GA25506@tyr.buserror.net>
Am 09.07.2012 16:04, schrieb Scott Wood:
> Recent patches "PPC: e500: rename mpc8544ds into generic file", "PPC:
> e500: split mpc8544ds machine from generic e500 code", and "PPC: e500:
> add generic e500 platform" moved certain e500-related files to the bottom
> of the makefile because they're now in ppc/, but the dependency on
> CONFIG_FDT was accidentally dropped. This broke the build when FDT
> support is not enabled.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
But this can probably still be squashed into the original patches for
bisectability I hope?
Andreas
> ---
> hw/ppc/Makefile.objs | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index 81bcc72..951e407 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -27,4 +27,4 @@ obj-y += xilinx_ethlite.o
>
> obj-y := $(addprefix ../,$(obj-y))
>
> -obj-y += e500.o mpc8544ds.o e500plat.o
> +obj-$(CONFIG_FDT) += e500.o mpc8544ds.o e500plat.o
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-09 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 14:04 [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT Scott Wood
2012-07-09 14:07 ` Andreas Färber [this message]
2012-07-09 14:36 ` Scott Wood
2012-07-09 14:37 ` Alexander Graf
2012-07-09 16:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAE5A8.4000308@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.