From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 09 Jul 2012 14:28:29 +0000 Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation Message-Id: <4FFAEA8D.1030202@freescale.com> List-Id: References: <1340864262-31651-1-git-send-email-Bharat.Bhushan@freescale.com> <19D972D8-56CB-4C79-9430-E1AFBA39D01F@suse.de> <4FF776D3.1070701@freescale.com> <5A60FB43-C554-4B72-8D86-AEA927F17503@suse.de> <6A3DF150A5B70D4F9B66A25E3F7C888D03DBE920@039-SN2MPN1-023.039d.mgd.msft.net> In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D03DBE920@039-SN2MPN1-023.039d.mgd.msft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bhushan Bharat-R65777 Cc: Alexander Graf , Wood Scott-B07421 , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" On 07/09/2012 12:13 AM, Bhushan Bharat-R65777 wrote: > > >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Saturday, July 07, 2012 1:21 PM >> To: Wood Scott-B07421 >> Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Bhushan >> Bharat-R65777 >> Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation >> >> >> Ah, being 2 bits wide, the above code suddenly makes more sense :). How about >> >> /* WRC is a 2-bit field that is supposed to preserve its value once written to >> be non-zero */ >> spr_val &= ~TCR_WRC_MASK; >> spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; >> kvmppc_set_tcr(vcpu, spr_val); > > I think you mean: > > if (TCR_WRC_MASK & vcpu->arch.tcr) { > spr_val &= ~TCR_WRC_MASK; > spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; > } > kvmppc_set_tcr(vcpu, spr_val); Actually I think he means: if (vcpu->arch.tcr & TCR_WRC_MASK) { spr_val &= ~TCR_WRC_MASK; spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; } kvmppc_set_tcr(vcpu, spr_val); :-) -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation Date: Mon, 9 Jul 2012 09:28:29 -0500 Message-ID: <4FFAEA8D.1030202@freescale.com> References: <1340864262-31651-1-git-send-email-Bharat.Bhushan@freescale.com> <19D972D8-56CB-4C79-9430-E1AFBA39D01F@suse.de> <4FF776D3.1070701@freescale.com> <5A60FB43-C554-4B72-8D86-AEA927F17503@suse.de> <6A3DF150A5B70D4F9B66A25E3F7C888D03DBE920@039-SN2MPN1-023.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Alexander Graf , Wood Scott-B07421 , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" To: Bhushan Bharat-R65777 Return-path: In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D03DBE920@039-SN2MPN1-023.039d.mgd.msft.net> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/09/2012 12:13 AM, Bhushan Bharat-R65777 wrote: > > >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Saturday, July 07, 2012 1:21 PM >> To: Wood Scott-B07421 >> Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Bhushan >> Bharat-R65777 >> Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation >> >> >> Ah, being 2 bits wide, the above code suddenly makes more sense :). How about >> >> /* WRC is a 2-bit field that is supposed to preserve its value once written to >> be non-zero */ >> spr_val &= ~TCR_WRC_MASK; >> spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; >> kvmppc_set_tcr(vcpu, spr_val); > > I think you mean: > > if (TCR_WRC_MASK & vcpu->arch.tcr) { > spr_val &= ~TCR_WRC_MASK; > spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; > } > kvmppc_set_tcr(vcpu, spr_val); Actually I think he means: if (vcpu->arch.tcr & TCR_WRC_MASK) { spr_val &= ~TCR_WRC_MASK; spr_val |= vcpu->arch.tcr & TCR_WRC_MASK; } kvmppc_set_tcr(vcpu, spr_val); :-) -Scott