Re: [PATCH 1/2] test-ussd becomes send-ussd

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi Marcel,

On 07/09/2012 11:39 AM, Marcel Holtmann wrote:
> Hi Denis,
>
>>> ---
>>>    test/send-ussd |   75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>    test/test-ussd |   75 --------------------------------------------------------
>>>    2 files changed, 75 insertions(+), 75 deletions(-)
>>>    create mode 100755 test/send-ussd
>>>    delete mode 100755 test/test-ussd
>>>
>>
>> Why don't we just get rid of test-ussd and create a new send-ussd script
>> that doesn't do any stdin handling.  Something along the lines of:
>>
>> ss.GetProperties()
>>
>> if state == 'idle'
>> 	rsp = ss.Initiate()
>> elif state == 'user-response'
>> 	rsp = ss.Respond()
>>
>> print response
>>
>> And perhaps another ussd related script that just cancels the request.
>> Would this satisfy your requirements?
>
> are the existing test/initiate-ussd and test/cancel-ussd not good
> enough?
>

initiate-ussd is close but not quite, it doesn't handle network 
initiated USSDs.

Anyway, the point here is that we need to get rid of test-ussd, it 
really serves no purpose.

Regards,
-Denis