Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command

[Orit Wasserman <owasserm@redhat.com>]

On 07/09/2012 11:59 PM, Eric Blake wrote:
> On 07/09/2012 12:22 PM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Benoit Hudzia <benoit.hudzia@sap.com>
>> Signed-off-by: Petter Svard <petters@cs.umu.se>
>> Signed-off-by: Aidan Shribman <aidan.shribman@sap.com>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> 
>> +++ b/qapi-schema.json
>> @@ -1390,6 +1390,22 @@
>>  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
> 
> We are copying after bad practice, but...
> 
>>  
>>  ##
>> +# @migrate_set_cachesize
> 
> ...new QMP commands should prefer '-' over '_'.  While the HMP version
> is fine with migrate_set_cachesize, the QMP command should be
> migrate-set-cachesize (or even 'migrate-set-cache-size').
> 
I will change it
Thanks,
Orit
> 
>> +
>> +Set cache size to be used by XBZRLE migration, the cache size will be round down
> 
> s/round/rounded/
>