Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support

[Dor Laor <dlaor@redhat.com>]

On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> Support the new PV EOI flag in kvm - it recently got merged
> into kvm.git. Set by default with -cpu kvm.
> Set for -cpu qemu by adding +kvm_pv_eoi.
> Clear by adding -kvm_pv_eoi to -cpu option.

What about adding them to our cpu models?
It should go w/o saying for all models (SandyBridge, OpteronGx,..) but 
there is the issue of backward compat. I remember we had a discussion 
about pair the models w/ the current machine type (-M) but I don't 
remember the final call.

What's your take Eduardo?

Cheers,
Dor

>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> 	rebased to uq/master
>
>   target-i386/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 5521709..ee1b64a 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
>   };
>
>   static const char *kvm_feature_name[] = {
> -    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> +    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>