From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754613Ab2GJI7k (ORCPT ); Tue, 10 Jul 2012 04:59:40 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:58868 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754516Ab2GJI7h (ORCPT ); Tue, 10 Jul 2012 04:59:37 -0400 X-IronPort-AV: E=Sophos;i="4.77,559,1336320000"; d="scan'208";a="5363941" Message-ID: <4FFBED84.1030905@cn.fujitsu.com> Date: Tue, 10 Jul 2012 16:53:24 +0800 From: Gao feng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Eric Dumazet CC: nhorman@tuxdriver.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, lizefan@huawei.com, tj@kernel.org, Eric Dumazet Subject: Re: [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup References: <1341837625.3265.2748.camel@edumazet-glaptop> <1341887508-20302-1-git-send-email-gaofeng@cn.fujitsu.com> <1341893650.3265.3974.camel@edumazet-glaptop> In-Reply-To: <1341893650.3265.3974.camel@edumazet-glaptop> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/07/10 16:52:55, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/07/10 16:59:18, Serialize complete at 2012/07/10 16:59:18 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Gao > > Is it still needed to call update_netdev_tables() from write_priomap() ? > Yes, I think it's needed,because read_priomap will show all of the net devices, But we may add the netdev after create a netprio cgroup, so the new added netdev's priomap will not be allocated. if we don't call update_netdev_tables in write_priomap, we may access this unallocated memory.