From: Paolo Bonzini <pbonzini@redhat.com>
To: minyard@acm.org
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface
Date: Tue, 10 Jul 2012 11:29:46 +0200 [thread overview]
Message-ID: <4FFBF60A.6030705@redhat.com> (raw)
In-Reply-To: <1341861429-6297-5-git-send-email-minyard@acm.org>
Il 09/07/2012 21:17, minyard@acm.org ha scritto:
> +
> +/* Phyical interface types. */
> +#define IPMI_KCS 1
> +#define IPMI_BT 2
> +#define IPMI_SMIC 3
The code is not 100% consistent for values that are defined in hardware
specs (enums are preferred for new code, but that's not really
enforced). However, for everything else please use enums rather than
arbitrary #defines.
Paolo
next prev parent reply other threads:[~2012-07-10 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 19:17 [Qemu-devel] First shot at adding IPMI to qemu minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 1/9] smbios: Add a function to directly add an entry minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 2/9] pc: move SMBIOS setup to after device init minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 3/9] isa: Add a way to query for a free interrupt minyard
2012-07-10 9:16 ` Paolo Bonzini
2012-07-09 19:17 ` [Qemu-devel] [PATCH 4/9] Add a base IPMI interface minyard
2012-07-10 9:17 ` Daniel P. Berrange
2012-07-10 11:12 ` Markus Armbruster
2012-07-10 16:19 ` Corey Minyard
2012-07-10 9:29 ` Paolo Bonzini [this message]
2012-07-09 19:17 ` [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure minyard
2012-07-10 9:17 ` Paolo Bonzini
2012-07-10 9:33 ` Paolo Bonzini
2012-07-10 20:00 ` Corey Minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 6/9] IPMI: Add a KCS low-level interface minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 7/9] IPMI: Add a BT " minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 8/9] IPMI: Add a local BMC simulation minyard
2012-07-09 19:17 ` [Qemu-devel] [PATCH 9/9] IPMI: Add an external connection simulation interface minyard
2012-07-10 9:35 ` [Qemu-devel] First shot at adding IPMI to qemu Paolo Bonzini
2012-07-10 15:43 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFBF60A.6030705@redhat.com \
--to=pbonzini@redhat.com \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.