From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access Date: Tue, 10 Jul 2012 12:41:54 +0200 Message-ID: <4FFC06F2.2010105@siemens.com> References: <35d20ce2ae928e21ff715c86f854860d164ff8c9.1340814444.git.jan.kiszka@siemens.com> <4FEC814C.9040808@redhat.com> <4FEDD9E7.9040702@siemens.com> <4FF164B4.50306@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Liu Ping Fan , Avi Kivity , kvm , qemu-devel To: Anthony Liguori Return-path: In-Reply-To: <4FF164B4.50306@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2012-07-02 11:07, Avi Kivity wrote: > On 06/29/2012 07:37 PM, Jan Kiszka wrote: >> Instead of flushing pending coalesced MMIO requests on every vmexit, >> this provides a mechanism to selectively flush when memory regions >> related to the coalesced one are accessed. This first of all includes >> the coalesced region itself but can also applied to other regions, e.g. >> of the same device, by calling memory_region_set_flush_coalesced. > > Looks fine. > > I have a hard time deciding whether this should go through the kvm tree > or memory tree. Anthony, perhaps you can commit it directly to avoid > the livelock? > > Reviewed-by: Avi Kivity > Anthony, ping? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoXtL-0002f2-Ct for qemu-devel@nongnu.org; Tue, 10 Jul 2012 06:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoXtJ-00020Q-Id for qemu-devel@nongnu.org; Tue, 10 Jul 2012 06:42:02 -0400 Received: from thoth.sbs.de ([192.35.17.2]:26654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoXtJ-000201-81 for qemu-devel@nongnu.org; Tue, 10 Jul 2012 06:42:01 -0400 Message-ID: <4FFC06F2.2010105@siemens.com> Date: Tue, 10 Jul 2012 12:41:54 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <35d20ce2ae928e21ff715c86f854860d164ff8c9.1340814444.git.jan.kiszka@siemens.com> <4FEC814C.9040808@redhat.com> <4FEDD9E7.9040702@siemens.com> <4FF164B4.50306@redhat.com> In-Reply-To: <4FF164B4.50306@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Marcelo Tosatti , Liu Ping Fan , Avi Kivity , kvm , qemu-devel On 2012-07-02 11:07, Avi Kivity wrote: > On 06/29/2012 07:37 PM, Jan Kiszka wrote: >> Instead of flushing pending coalesced MMIO requests on every vmexit, >> this provides a mechanism to selectively flush when memory regions >> related to the coalesced one are accessed. This first of all includes >> the coalesced region itself but can also applied to other regions, e.g. >> of the same device, by calling memory_region_set_flush_coalesced. > > Looks fine. > > I have a hard time deciding whether this should go through the kvm tree > or memory tree. Anthony, perhaps you can commit it directly to avoid > the livelock? > > Reviewed-by: Avi Kivity > Anthony, ping? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux