From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [RFC] drm/radeon: restoring ring commands in case of a lockup Date: Tue, 10 Jul 2012 14:54:57 +0200 Message-ID: <4FFC2621.6050809@vodafone.de> References: <1341830523-30320-1-git-send-email-deathsimple@vodafone.de> <1341849568.12576.285.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id B0C8EA09EC for ; Tue, 10 Jul 2012 05:54:59 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: =?ISO-8859-1?Q?Michel_D=E4nzer?= , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 09.07.2012 18:10, Jerome Glisse wrote: > On Mon, Jul 9, 2012 at 11:59 AM, Michel D=E4nzer wro= te: >> On Mon, 2012-07-09 at 12:41 +0200, Christian K=F6nig wrote: >>> Hi, >>> >>> The following patchset tries to save and restore the not yet processed = commands >>> from the rings in case of a lockup and with that should make a userspace >>> problem with a single application far less problematic. >>> >>> The first four patches are just stuff this patchset is based upon, foll= owed by >>> four patches which fix various bugs found while working on this feature. >>> >>> Followed by patches which change the way how memory is saved/restored on >>> suspend/resume, basically before we have unpinned most of the buffer ob= jects so >>> it could be move from vram into system memory. But that is mostly unnec= essary >>> cause the buffer object either are already in system memory or their co= ntent >>> can be easily reinitialized. >>> >>> The last three patches implement the actual tracking and restoring of c= ommands >>> in case of a lockup. Please take a look and review. >> Patches 3, 5 and 14 are >> >> Reviewed-by: Michel D=E4nzer >> > Patch 1-9 are > Reviewed-by: Jerome Glisse > > Other looks good but i want to test them too and spend a bit more time > to double check few things. Will try to do that tomorrow. Just send out v2 of the patchset. Mainly it integrates your idea of just = saving rptr right before we call into the IB, but also contains all the = other comments and fixes from Michel. Cheers, Christian.