From: Phillip Susi <psusi@ubuntu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
dm-devel@redhat.com, kzak@redhat.com, maxim.patlasov@gmail.com
Subject: Re: [patch 0/2] [V4] block: Support online resize of disk partitions
Date: Tue, 10 Jul 2012 10:13:19 -0400 [thread overview]
Message-ID: <4FFC387F.3070308@ubuntu.com> (raw)
In-Reply-To: <20120710135759.GE14884@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 7/10/2012 9:57 AM, Vivek Goyal wrote:
> +static inline sector_t part_nr_sects_read(struct hd_struct *part)
> +{ +#if BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
> defined(CONFIG_SMP) + sector_t nr_sects; + unsigned seq; + do { +
> seq = read_seqcount_begin(&part->nr_sects_seq); + nr_sects =
> part->nr_sects; + } while (read_seqcount_retry(&part->nr_sects_seq,
> seq)); + return nr_sects; +#elif BITS_PER_LONG==32 &&
> defined(CONFIG_PREEMPT)
Shouldn't this be BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
defined(CONFIG_PREEMPT)? No sense disabling preemption when the
sector size is also 32 bits.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJP/Dh/AAoJEJrBOlT6nu75ussIANfCKaObXMJ6JhCNLSeiHUqr
FfBd6p2lJIFd73NSymyigZZ1/rPsy9TpMBlcMwpuFh2erxQ7q3rFnP0O52fEgm2+
20c9+oeUGkzYx62fh0KtfrzBpzhiHOivKR/muAZcfNbb75iKTGrZSZUFrdqAqHci
4zCuu8T37BRo4G9TGdIXD1WT3sltZ7yOk4I7RBhAIDkbt82vVakZ6mlW9hyWmyvD
/sMnXMmkNjwTDdhQj2ho9mn9SFcnDA+aAtJfPXjVAT0W9CKNDYbXw28ud+ARxo5T
rkTjoewdxKffZsBmkkSiNCuLWwpkZng+nTchQjyZbmp/pl4UPlQOfcUb6YxpDX4=
=1tUj
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-07-10 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 21:34 [patch 0/2] [V4] block: Support online resize of disk partitions vgoyal
2012-07-09 21:34 ` [patch 1/2] block: add partition resize function to blkpg ioctl vgoyal
2012-07-09 21:34 ` [patch 2/2] util-linux: resizepart: Utility to resize a partition vgoyal
2012-08-13 20:20 ` Karel Zak
2012-08-13 20:20 ` Karel Zak
2012-07-09 22:40 ` [patch 0/2] [V4] block: Support online resize of disk partitions Phillip Susi
2012-07-10 13:57 ` Vivek Goyal
2012-07-10 14:13 ` Phillip Susi [this message]
2012-07-10 14:20 ` Vivek Goyal
2012-07-10 14:59 ` Vivek Goyal
2012-08-01 14:07 ` Vivek Goyal
2012-08-01 15:49 ` Jens Axboe
2012-08-01 15:59 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC387F.3070308@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.patlasov@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.