Re: [PATCH] mfd: Remove __devexit annotation for pm80x_deinit

[Qiao Zhou <zhouqiao@marvell.com>]

On 07/11/2012 09:48 AM, Axel Lin wrote:
> This fixes below section mismatch warning:
>
>    LD      drivers/mfd/built-in.o
> WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit()
> The function __devinit pm800_probe() references
> a function __devexit pm80x_deinit().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __devexit annotation of
> pm80x_deinit() so it may be used outside an exit section.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>   drivers/mfd/88pm80x.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/88pm80x.c b/drivers/mfd/88pm80x.c
> index 62da342..cd0bf52 100644
> --- a/drivers/mfd/88pm80x.c
> +++ b/drivers/mfd/88pm80x.c
> @@ -91,7 +91,7 @@ err_regmap_init:
>   }
>   EXPORT_SYMBOL_GPL(pm80x_init);
>
> -int __devexit pm80x_deinit(struct i2c_client *client)
> +int pm80x_deinit(struct i2c_client *client)
>   {
>   	struct pm80x_chip *chip = i2c_get_clientdata(client);
>
>
Alex,

thanks again for the fixing, and would try to avoid such warning in future.

-- 

Best Regards
Qiao