From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rajeev kumar <rajeev-dlh.kumar@st.com>
Subject: Re: [patch] ASoC: STA529: fix an error message
Date: Wed, 11 Jul 2012 12:21:01 +0530
Message-ID: <4FFD2255.1040102@st.com>
References: <20120711064123.GI11812@elgon.mountain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from eu1sys200aog114.obsmtp.com (eu1sys200aog114.obsmtp.com
	[207.126.144.137])
	by alsa0.perex.cz (Postfix) with ESMTP id 6161B24156
	for <alsa-devel@alsa-project.org>;
	Wed, 11 Jul 2012 08:51:10 +0200 (CEST)
In-Reply-To: <20120711064123.GI11812@elgon.mountain>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@opensource.wolfsonmicro.com>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, Liam Girdwood <lrg@ti.com>
List-Id: alsa-devel@alsa-project.org

Hello Dan,

On 7/11/2012 12:11 PM, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
> index a9f34c7..0c225cd 100644
> --- a/sound/soc/codecs/sta529.c
> +++ b/sound/soc/codecs/sta529.c
> @@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
>
>   	sta529->regmap = devm_regmap_init_i2c(i2c,&sta529_regmap);
>   	if (IS_ERR(sta529->regmap)) {
> +		ret = PTR_ERR(sta529->regmap);
>   		dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
> -		return PTR_ERR(sta529->regmap);
> +		return ret;
>   	}
>
>   	i2c_set_clientdata(i2c, sta529);
> .
>

Thanks for the patch.

Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>

~Rajeev

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rajeev kumar <rajeev-dlh.kumar@st.com>
Date: Wed, 11 Jul 2012 06:55:30 +0000
Subject: Re: [patch] ASoC: STA529: fix an error message
Message-Id: <4FFD2255.1040102@st.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120711064123.GI11812@elgon.mountain>
In-Reply-To: <20120711064123.GI11812@elgon.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@opensource.wolfsonmicro.com>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, Liam Girdwood <lrg@ti.com>

Hello Dan,

On 7/11/2012 12:11 PM, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
> index a9f34c7..0c225cd 100644
> --- a/sound/soc/codecs/sta529.c
> +++ b/sound/soc/codecs/sta529.c
> @@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
>
>   	sta529->regmap = devm_regmap_init_i2c(i2c,&sta529_regmap);
>   	if (IS_ERR(sta529->regmap)) {
> +		ret = PTR_ERR(sta529->regmap);
>   		dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
> -		return PTR_ERR(sta529->regmap);
> +		return ret;
>   	}
>
>   	i2c_set_clientdata(i2c, sta529);
> .
>

Thanks for the patch.

Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>

~Rajeev