All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: Include arch specific gpio.h
Date: Wed, 11 Jul 2012 10:19:09 +0200	[thread overview]
Message-ID: <4FFD36FD.3070300@monstr.eu> (raw)
In-Reply-To: <CAPnjgZ3O+2vBqgy35AxPH=8YyWf9BmE2MGOy8Mws82aS=+ZQ0A@mail.gmail.com>

On 07/10/2012 11:13 PM, Simon Glass wrote:
> Hi Michal,
>
> On Tue, Jul 10, 2012 at 11:56 AM, Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu>> wrote:
>
>     Also include arch specific gpio.h which can contain
>     gpio function implementation.
>
>     Signed-off-by: Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu>>
>     CC: Simon Glass <sjg at chromium.org <mailto:sjg@chromium.org>>
>     ---
>       lib/fdtdec.c |    1 +
>       1 files changed, 1 insertions(+), 0 deletions(-)
>
>     diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>     index cc09e06..b12eb77 100644
>     --- a/lib/fdtdec.c
>     +++ b/lib/fdtdec.c
>     @@ -25,6 +25,7 @@
>       #include <fdtdec.h>
>
>       /* we need the generic GPIO interface here */
>     +#include <asm/gpio.h>
>
>
> Can you not instead support the generic functions? What are you missing from from there that fdtdec.c needs?

OK. The problem is with fdtdec_setup_gpio function where you called gpio_request which
is gpio specific function which you haven't included.

The most archs have this defined in arch/<cpuname>/include/asm/gpio.h.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

  reply	other threads:[~2012-07-11  8:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  9:56 [U-Boot] [PATCH] fdt: Include arch specific gpio.h Michal Simek
2012-07-10 21:13 ` Simon Glass
2012-07-11  8:19   ` Michal Simek [this message]
2012-07-11  9:59     ` Simon Glass
2012-07-11 10:43       ` Michal Simek
2012-07-11 10:59         ` Simon Glass
2012-07-11 11:21           ` Michal Simek
2012-07-11 12:00             ` Simon Glass
2012-07-11 12:21               ` Michal Simek
2012-07-11 21:02                 ` Joe Hershberger
2012-07-12  5:05                   ` Simon Glass
2012-07-12  5:33                   ` Michal Simek
2012-07-12  5:38                     ` Simon Glass
2012-07-12 16:37             ` Joe Hershberger
2012-07-13  5:43               ` Michal Simek
  -- strict thread matches above, loose matches on Subject: below --
2012-06-29  7:28 Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFD36FD.3070300@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.