From: Ian Abbott <abbotti@mev.co.uk>
To: Ian Abbott <ian.abbott@mev.co.uk>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 00/83] staging: comedi: rtd520: initial cleanup
Date: Wed, 11 Jul 2012 11:33:09 +0100 [thread overview]
Message-ID: <4FFD5665.7040901@mev.co.uk> (raw)
In-Reply-To: <4FFD536B.8010603@mev.co.uk>
On 2012-07-11 11:20, Ian Abbott wrote:
> On 2012-07-11 00:36, H Hartley Sweeten wrote:
> My main concern with this series of patches is they make it harder to
> determine what the register accesses actually do, mainly due to the
> removal of useful comments. For example:
>
> - RtdPacerStart(dev); /* Start PACER */
> + readl(devpriv->las0 + LAS0_PACER);
>
> And:
>
> - RtdPacerStop(dev); /* Stop PACER */
> + writel(0, devpriv->las0 + LAS0_PACER);
It would be too much work to redo all those patches though. I'll just
make a patch to add back in the useful-looking comments.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-07-11 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 23:36 [PATCH 00/83] staging: comedi: rtd520: initial cleanup H Hartley Sweeten
2012-07-11 10:20 ` Ian Abbott
2012-07-11 10:33 ` Ian Abbott [this message]
2012-07-11 12:28 ` [PATCH] staging: comedi: rtd520: add a few comments Ian Abbott
2012-07-11 16:30 ` H Hartley Sweeten
2012-07-11 16:27 ` [PATCH 00/83] staging: comedi: rtd520: initial cleanup H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD5665.7040901@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.