From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
ycheng@google.com, dave.taht@gmail.com, netdev@vger.kernel.org,
codel@lists.bufferbloat.net, therbert@google.com,
mattmathis@google.com, nanditad@google.com, ncardwell@google.com,
andrewmcgr@gmail.com, Rick Jones <rick.jones2@hp.com>
Subject: Re: [RFC PATCH v2] tcp: TCP Small Queues
Date: Wed, 11 Jul 2012 08:43:20 -0700 [thread overview]
Message-ID: <4FFD9F18.6030401@candelatech.com> (raw)
In-Reply-To: <1342020306.3265.8129.camel@edumazet-glaptop>
On 07/11/2012 08:25 AM, Eric Dumazet wrote:
> On Wed, 2012-07-11 at 08:16 -0700, Ben Greear wrote:
>
>> I haven't read your patch in detail, but I was wondering if this feature
>> would cause trouble for applications that are servicing many sockets at once
>> and so might take several ms between handling each individual socket.
>>
>
> Well, this patch has no impact for such applications. In fact their
> send()/write() will return to userland faster than before (for very
> large send())
Maybe I'm just confused. Is your patch just mucking with
the queues below the tcp xmit queues? From the patch description
I was thinking you were somehow directly limiting the TCP xmit
queues...
If you are just draining the tcp xmit queues on a new/faster
trigger, then I see no problem with that, and no need for
a per-socket control.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-07-11 15:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 17:07 [PATCH net-next] fq_codel: report congestion notification at enqueue time Eric Dumazet
2012-06-28 17:51 ` Dave Taht
2012-06-28 18:12 ` Eric Dumazet
2012-06-28 22:56 ` Yuchung Cheng
2012-06-28 23:47 ` Dave Taht
2012-06-29 4:50 ` Eric Dumazet
2012-06-29 5:24 ` Dave Taht
2012-07-04 10:11 ` [RFC PATCH] tcp: limit data skbs in qdisc layer Eric Dumazet
2012-07-09 7:08 ` David Miller
2012-07-09 8:03 ` Eric Dumazet
2012-07-09 8:48 ` Eric Dumazet
2012-07-09 14:55 ` Eric Dumazet
2012-07-10 13:28 ` Lin Ming
2012-07-10 15:13 ` [RFC PATCH v2] tcp: TCP Small Queues Eric Dumazet
2012-07-10 17:06 ` Eric Dumazet
2012-07-10 17:37 ` Yuchung Cheng
2012-07-10 18:32 ` Eric Dumazet
2012-07-11 15:11 ` Eric Dumazet
2012-07-11 15:16 ` Ben Greear
2012-07-11 15:25 ` Eric Dumazet
2012-07-11 15:43 ` Ben Greear [this message]
2012-07-11 15:54 ` Eric Dumazet
2012-07-11 16:03 ` Ben Greear
2012-07-11 18:23 ` Rick Jones
2012-07-11 23:38 ` Eric Dumazet
2012-07-11 18:44 ` Rick Jones
2012-07-11 23:49 ` Eric Dumazet
2012-07-12 7:34 ` Eric Dumazet
2012-07-12 7:37 ` David Miller
2012-07-12 7:51 ` Eric Dumazet
2012-07-12 14:55 ` Tom Herbert
2012-07-12 13:33 ` John Heffner
2012-07-12 13:46 ` Eric Dumazet
2012-07-12 16:44 ` John Heffner
2012-07-12 16:54 ` Jim Gettys
2012-06-28 23:52 ` [PATCH net-next] fq_codel: report congestion notification at enqueue time Nandita Dukkipati
2012-06-29 4:18 ` Eric Dumazet
2012-06-29 4:53 ` Eric Dumazet
2012-06-29 5:12 ` David Miller
2012-06-29 5:24 ` Eric Dumazet
2012-06-29 5:29 ` David Miller
2012-06-29 5:50 ` Eric Dumazet
2012-06-29 7:53 ` David Miller
2012-06-29 8:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD9F18.6030401@candelatech.com \
--to=greearb@candelatech.com \
--cc=andrewmcgr@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mattmathis@google.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.