From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Luis Vazquez Cao Subject: Re: [PATCH 1/7] fsfreeze: Prevent emergency thaw from looping infinitely Date: Thu, 12 Jul 2012 10:49:21 +0900 Message-ID: <4FFE2D21.3060607@lab.ntt.co.jp> References: <1341908216.11559.6.camel@nexus.lab.ntt.co.jp> <1341908457.11559.9.camel@nexus.lab.ntt.co.jp> <20120710120858.GD13539@quack.suse.cz> <4FFCE434.601@lab.ntt.co.jp> <20120711090230.GC1316@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Al Viro , Dave Chinner , Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:49836 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756323Ab2GLBts (ORCPT ); Wed, 11 Jul 2012 21:49:48 -0400 In-Reply-To: <20120711090230.GC1316@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2012/07/11 18:02, Jan Kara wrote: > Yes, after your patch thaw_bdev() returns EINVAL although the device is > thawed. That is just wrong regardless whether any caller cares or not. And > before your patch this was working correctly. So please fix your patch. I will fix it for the next iteration of the patch set. Thanks, Fernando