From: Ian Abbott <abbotti@mev.co.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ian Abbott <ian.abbott@mev.co.uk>,
H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device
Date: Thu, 12 Jul 2012 10:02:30 +0100 [thread overview]
Message-ID: <4FFE92A6.2070106@mev.co.uk> (raw)
In-Reply-To: <20120712100213.4be0e50f@pyramind.ukuu.org.uk>
On 2012/07/12 10:02 AM, Alan Cox wrote:
>> I suppose at a later date we could turn that into a union with a short
>> name like u (so comedidev->pcidev would become something like
>> comedidev->u.pcidev), which would allow us to stick a 'struct
>> usb_interface *' or some other hardware device wrapper struct pointer in
>> the same hole. (Maybe 'h' for 'hardware' would be better than 'u'.)
>
> The "usual" pattern is to make it a struct device pointer. Then you can
> get to any other kind of device from it.
You mean with container_of(), right? Actually, 'struct comedi_device'
already has a little-used 'struct device *hw_dev' member that could be
used for this purpose.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2012-07-12 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 21:47 [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device H Hartley Sweeten
2012-07-12 8:55 ` Ian Abbott
2012-07-12 9:02 ` Alan Cox
2012-07-12 9:02 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFE92A6.2070106@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.