From: Kevin Wolf <kwolf@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
riegamaths@gmail.com, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] qemu-img: correct help message
Date: Thu, 12 Jul 2012 11:29:40 +0200 [thread overview]
Message-ID: <4FFE9904.9080007@redhat.com> (raw)
In-Reply-To: <1342063681-957-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Am 12.07.2012 05:28, schrieb Dong Xu Wang:
> qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct
> it in help message.
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> CC: riegamaths@gmail.com
> ---
> v1->v2: also correct error reporting.
This is only true for some cases. For example, img_resize uses a
different parser (parse_option_size), which only supports the format
described here.
There's probably little reason to keep two different parsers, though, so
when the duplication is fixed, the help text can be updated as well.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
riegamaths@gmail.com, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: correct help message
Date: Thu, 12 Jul 2012 11:29:40 +0200 [thread overview]
Message-ID: <4FFE9904.9080007@redhat.com> (raw)
In-Reply-To: <1342063681-957-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Am 12.07.2012 05:28, schrieb Dong Xu Wang:
> qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct
> it in help message.
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> CC: riegamaths@gmail.com
> ---
> v1->v2: also correct error reporting.
This is only true for some cases. For example, img_resize uses a
different parser (parse_option_size), which only supports the format
described here.
There's probably little reason to keep two different parsers, though, so
when the duplication is fixed, the help text can be updated as well.
Kevin
next prev parent reply other threads:[~2012-07-12 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 3:28 [Qemu-trivial] [PATCH v2] qemu-img: correct help message Dong Xu Wang
2012-07-12 3:28 ` [Qemu-devel] " Dong Xu Wang
2012-07-12 9:29 ` Kevin Wolf [this message]
2012-07-12 9:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFE9904.9080007@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riegamaths@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.