All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers
Date: Thu, 12 Jul 2012 20:44:53 +0530	[thread overview]
Message-ID: <4FFEE9ED.6020906@qca.qualcomm.com> (raw)
In-Reply-To: <1342103072.4531.26.camel@jlt3.sipsolutions.net>

Hi Johannes,

thanks for getting back to this :)

On Thursday 12 July 2012 07:54 PM, Johannes Berg wrote:
> On Wed, 2012-07-11 at 11:03 +0530, Mohammed Shafi Shajakhan wrote:
>
>>> I don't know if there's any advantage. It could be useful for example to
>>> get a connection up quicker after resume. I just didn't want to preclude
>>> that use case.
>>>
>>
>> sorry i just missed this thing. rdev->wowlan is made 'false' for empty
>
> I think you mean "NULL"?

oh yes.

>
> Maybe something like this would make sense then?
>
> http://p.sipsolutions.net/2aac79bcfe3a9b8b.txt

yeah this was the thing i am proposing
http://www.spinics.net/lists/linux-wireless/msg94023.html

your patch is better optimized as it avoids a bool variable to check for 
wow disable command, so this should be fine with the other iw
patch to check for empty triggers ?
http://www.spinics.net/lists/linux-wireless/msg94022.html

thank you!

>
> johannes
>


-- 
thanks,
shafi



  reply	other threads:[~2012-07-12 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 10:07 [RFC] nl80211: Avoid checking for empty WoWLAN triggers Mohammed Shafi Shajakhan
2012-07-10 11:06 ` Johannes Berg
2012-07-10 11:16   ` Mohammed Shafi Shajakhan
2012-07-10 11:20     ` Johannes Berg
2012-07-10 11:36       ` Mohammed Shafi Shajakhan
2012-07-11  5:33       ` Mohammed Shafi Shajakhan
2012-07-12 14:24         ` Johannes Berg
2012-07-12 15:14           ` Mohammed Shafi Shajakhan [this message]
2012-07-12 15:17             ` Johannes Berg
2012-07-12 15:33               ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFEE9ED.6020906@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.