From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers
Date: Thu, 12 Jul 2012 21:03:03 +0530 [thread overview]
Message-ID: <4FFEEE2F.9040104@qca.qualcomm.com> (raw)
In-Reply-To: <1342106232.4531.31.camel@jlt3.sipsolutions.net>
On Thursday 12 July 2012 08:47 PM, Johannes Berg wrote:
> Hi,
>
>>> Maybe something like this would make sense then?
>>>
>>> http://p.sipsolutions.net/2aac79bcfe3a9b8b.txt
>>
>> yeah this was the thing i am proposing
>> http://www.spinics.net/lists/linux-wireless/msg94023.html
>>
>> your patch is better optimized as it avoids a bool variable to check for
>> wow disable command, so this should be fine with the other iw
>> patch to check for empty triggers ?
>> http://www.spinics.net/lists/linux-wireless/msg94022.html
>
> Well, my patch is different, it actually allows empty triggers to go
> through as I had explained.
oops, sorry i misread it.
>
> I'm just not sure which one makes more sense? I kinda feel that allowing
> empty triggers might be a corner case but useful, while disallowing it
> now would make it hard to ever support such a case?
i am fine with your approach itself and don't want to break that use case.
>
> johannes
>
--
thanks,
shafi
prev parent reply other threads:[~2012-07-12 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:07 [RFC] nl80211: Avoid checking for empty WoWLAN triggers Mohammed Shafi Shajakhan
2012-07-10 11:06 ` Johannes Berg
2012-07-10 11:16 ` Mohammed Shafi Shajakhan
2012-07-10 11:20 ` Johannes Berg
2012-07-10 11:36 ` Mohammed Shafi Shajakhan
2012-07-11 5:33 ` Mohammed Shafi Shajakhan
2012-07-12 14:24 ` Johannes Berg
2012-07-12 15:14 ` Mohammed Shafi Shajakhan
2012-07-12 15:17 ` Johannes Berg
2012-07-12 15:33 ` Mohammed Shafi Shajakhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFEEE2F.9040104@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.