All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: valgrind support
Date: Thu, 12 Jul 2012 19:14:04 +0200	[thread overview]
Message-ID: <4FFF05DC.50204@weilnetz.de> (raw)
In-Reply-To: <4FFF00AB.2060705@redhat.com>

Am 12.07.2012 18:51, schrieb Paolo Bonzini:
> Il 12/07/2012 16:27, Kevin Wolf ha scritto:
>> Kevin Wolf (2):
>>    coroutine-ucontext: Help valgrind understand coroutines
>>    qemu-iotests: Valgrind support
>>
>>   configure                    |   18 ++++++++++++++++++
>>   coroutine-ucontext.c         |   21 +++++++++++++++++++++
>>   tests/qemu-iotests/common    |   11 +++++++++++
>>   tests/qemu-iotests/common.rc |   10 ++++++++++
>>   4 files changed, 60 insertions(+), 0 deletions(-)
>>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Hi Paolo,

at least the data type of the Valgrind stack id should be fixed
(see my previous mail which I wrote while you was sending
your review).

Cheers,

Stefan

      reply	other threads:[~2012-07-12 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 14:27 [Qemu-devel] [PATCH 0/2] qemu-iotests: valgrind support Kevin Wolf
2012-07-12 14:27 ` [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines Kevin Wolf
2012-07-12 17:07   ` Stefan Weil
2012-07-13  8:45     ` Kevin Wolf
2012-07-13  8:53       ` Kevin Wolf
2012-07-12 17:14   ` Peter Maydell
2012-07-13  8:36     ` Kevin Wolf
2012-07-13 15:31   ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2012-07-13 15:37     ` Peter Maydell
2012-07-13 16:06       ` Kevin Wolf
2012-07-13 16:13         ` Eric Blake
2012-07-13 16:18           ` Kevin Wolf
2012-07-12 14:27 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Valgrind support Kevin Wolf
2012-07-12 16:51 ` [Qemu-devel] [PATCH 0/2] qemu-iotests: valgrind support Paolo Bonzini
2012-07-12 17:14   ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFF05DC.50204@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.