Re: [PATCH 1/5] v4l2: Add rangelow and rangehigh fields to the v4l2_hw_freq_seek struct

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 07/12/2012 11:27 AM, Hans Verkuil wrote:
> On Wed 11 July 2012 20:37:14 Hans de Goede wrote:

<snip>

>>> 2) What happens if the current frequency is outside the low/high range? The
>>> hwseek spec says that the seek starts from the current frequency, so that might
>>> mean that hwseek returns -ERANGE in this case.
>>
>> What the si470x code currently does is just clamp the frequency to the new
>> range before seeking, but -ERANGE works for me too.
>
> Clamping is a better idea IMHO as long as it is documented.

Ok, I've respun this patch to improve the documentation in various parts, I'm
resending the entire set right after this email.

Regards,

Hans

p.s.

Tomorrow morning I'm leaving for a week of vacation, during which I won't be
reading my mail. If everybody agrees on the 2nd revision of this patchset
please add it to your bands2 branch, and if you agree that this seems to be
it wrt the API for tuner-bands, you could also consider sending a pull-req
for it to Mauro for 3.6 :)