From: vipulkumar.samar@st.com (vipul kumar samar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] clk:spear1340:Fix: Rename clk ids within predefined limit
Date: Fri, 13 Jul 2012 13:48:53 +0530 [thread overview]
Message-ID: <4FFFD9ED.30606@st.com> (raw)
In-Reply-To: <CAOh2x==4rQhAvZmmqiyi0jhF0Zz=v8OmuCBaFGFehOEt2kyd1w@mail.gmail.com>
On 7/13/2012 1:36 PM, viresh kumar wrote:
> On Fri, Jul 13, 2012 at 7:23 AM, Vipul Kumar Samar
> <vipulkumar.samar@st.com> wrote:
>> The max limit of con_id is 16 and dev_id is 20. As of now for spear1340, many
>> clk ids are exceeding this predefined limit.
>>
>> diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c
>
>> @@ -509,23 +507,23 @@ void __init spear1340_clk_init(void)
>
>> - clk_register_clkdev(clk1, "uart0_synth_gate_clk", NULL);
>
>> - clk_register_clkdev(clk1, "sdhci_synth_gate_clk", NULL);
>
>> - clk_register_clkdev(clk, "gmac_phy_input_mux_clk", NULL);
>> - clk_register_clkdev(clk1, "gmac_phy_synth_gate_clk", NULL);
>
> These are the only places in this entire patch, where i found con_id
> crossing the limit.
> Then why so many changes? Aligning all to similar naming?
Not only for gmac some other ips also like sdhi_synth_gate_clk,
uart1_synth_gate_clk, clcd_synth_mux_clk etc.
yes, to align all other gate, synth and mux clocks with similar naming.
>
>
>> clk_register_clkdev(clk, NULL, "e0000000.serial");
>
> @Russell& Mike: Above line uses maximum length of dev_id, i.e. 16.
> And because with DT we have so long device names now, out of which
> 8 - address
> 1 - '.'
> 1 - '\0'
>
> 10 are already gone and so only 6 are left for device name. Should we
> consider updating
> dev_id array size??
dev_id is 20 and con_id is 16
Regards
Vipul Samar
next prev parent reply other threads:[~2012-07-13 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 6:23 [PATCH 0/4] clk:spear: Rename clk ids within predefined limit Vipul Kumar Samar
2012-07-13 6:23 ` [PATCH 1/4] clk:spear1340:Fix: " Vipul Kumar Samar
2012-07-13 8:06 ` viresh kumar
2012-07-13 8:10 ` viresh kumar
2012-07-13 8:18 ` vipul kumar samar [this message]
2012-07-13 6:23 ` [PATCH 2/4] clk:spear1310:Fix: " Vipul Kumar Samar
2012-07-13 6:23 ` [PATCH 3/4] Clk:spear3xx:Fix: " Vipul Kumar Samar
2012-07-13 6:23 ` [PATCH 4/4] Clk:spear6xx:Fix: " Vipul Kumar Samar
2012-07-13 8:13 ` [PATCH 0/4] clk:spear: " viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFFD9ED.30606@st.com \
--to=vipulkumar.samar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.