From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
"Jose A . Perez de Azpillaga" <azpijr@gmail.com>,
"Liam R. Howlett" <liam@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v2 0/3] mm/memory: remove unused vmf_insert_mixed_mkwrite()
Date: Wed, 18 Nov 2026 15:48:55 +0100 [thread overview]
Message-ID: <4a1edf5e-2e15-4cd0-a032-5ad579111713@kernel.org> (raw)
In-Reply-To: <20261002160535.661399-1-ekffu200098@gmail.com>
On 10/2/26 18:05, Sang-Heon Jeon wrote:
> Hello,
>
> Since commit 38607c62b34b ("fs/dax: properly refcount fs dax pages"),
> vmf_insert_mixed_mkwrite() has no callers. This series removes it and
> the mkwrite handling that only it used.
>
> Patch 1 removes the function.
>
> Patch 2 removes the mkwrite argument, which is then always false. It
> also removes the unreachable code in insert_pfn().
>
> Patch 3 merges __vm_insert_mixed() into vmf_insert_mixed().
>
> No functional change.
>
> ---
> Changes from v1 [1]
> - Split into three patches for easier review
> - Move the comment about -EBUSY handling above the check in
> __vm_insert_mixed()
>
> [1] https://lore.kernel.org/all/20260929143707.450805-1-ekffu200098@gmail.com/
> ---
>
> Sang-Heon Jeon (3):
> mm/memory: remove unused vmf_insert_mixed_mkwrite()
> mm/memory: remove the mkwrite argument from __vm_insert_mixed()
> mm/memory: merge __vm_insert_mixed() into vmf_insert_mixed()
Hi Andrew,
please drop these changes, I'll queue them myself after applying a fix from Mike
in that area.
--
Cheers,
David
next prev parent reply other threads:[~2026-11-18 14:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 16:05 [PATCH v2 0/3] mm/memory: remove unused vmf_insert_mixed_mkwrite() Sang-Heon Jeon
2026-10-02 16:05 ` [PATCH v2 1/3] " Sang-Heon Jeon
2026-10-02 18:35 ` SJ Park
2026-10-02 23:32 ` Jose A. Perez de Azpillaga
2026-10-05 2:36 ` Anshuman Khandual
2026-11-18 14:57 ` David Hildenbrand (Arm)
2026-11-19 13:46 ` Lorenzo Stoakes (ARM)
2026-10-02 16:05 ` [PATCH v2 2/3] mm/memory: remove the mkwrite argument from __vm_insert_mixed() Sang-Heon Jeon
2026-10-02 18:45 ` SJ Park
2026-10-02 23:34 ` Jose A. Perez de Azpillaga
2026-10-05 2:40 ` Anshuman Khandual
2026-11-18 14:58 ` David Hildenbrand (Arm)
2026-11-19 13:56 ` Lorenzo Stoakes (ARM)
2026-10-02 16:05 ` [PATCH v2 3/3] mm/memory: merge __vm_insert_mixed() into vmf_insert_mixed() Sang-Heon Jeon
2026-10-02 18:47 ` SJ Park
2026-10-02 23:35 ` Jose A. Perez de Azpillaga
2026-10-05 3:14 ` Anshuman Khandual
2026-11-18 14:58 ` David Hildenbrand (Arm)
2026-11-19 13:58 ` Lorenzo Stoakes (ARM)
2026-11-18 14:48 ` David Hildenbrand (Arm) [this message]
2026-11-18 15:06 ` [PATCH v2 0/3] mm/memory: remove unused vmf_insert_mixed_mkwrite() David Hildenbrand
2026-11-19 12:36 ` Gupta, Pankaj
2026-11-19 16:52 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a1edf5e-2e15-4cd0-a032-5ad579111713@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=azpijr@gmail.com \
--cc=ekffu200098@gmail.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.