From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBD3CC4332F for ; Fri, 25 Nov 2022 09:48:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5C16540436; Fri, 25 Nov 2022 09:48:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5C16540436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1669369728; bh=zwfnw+lWQGYGZKoyJBlxSXAoyp8QfCYn57E1RUfqpLI=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=cScpu6zLXJfUOmyc4L0N7DvAIngl8A5OI0aJZIFkplETdJWE+YXiQVKR8axlCHR8I KOxuzNDYW8bbF8EuXjwE63NS+Z0tu9qkxICgFCVtMujITTrgpWk+Hu4KzsO83l3OT2 osCgPXEoQ6q7sAj01b8FzK5x9efey/GAkO+ppJAvJnPgmjn6aEbRfmAV8JDNf44lKj BrHyHeEznz3LOp0H536m/ZY0tTNbFdkcN/c2TGI7gErdyj30JVuhqNB/Zy4tBzue/9 CN6Kci6lal1ttZrJeUIcS4xhNLfJfLTUfjMu8db9bO0EF6ctd61MifQAPRtpenIZGd rBaRBDw7lLK0A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q4CwgjUJe9KK; Fri, 25 Nov 2022 09:48:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 56DE640459; Fri, 25 Nov 2022 09:48:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 56DE640459 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id ED7161BF2B4 for ; Fri, 25 Nov 2022 09:48:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C468A60BB8 for ; Fri, 25 Nov 2022 09:48:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C468A60BB8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vA4IrjfDXH79 for ; Fri, 25 Nov 2022 09:48:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6D72160AD1 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6D72160AD1 for ; Fri, 25 Nov 2022 09:48:44 +0000 (UTC) Received: by mail-pl1-x631.google.com with SMTP id k7so3529760pll.6 for ; Fri, 25 Nov 2022 01:48:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fh9lKt/Ex1PEWTAeH6nLeKPXEkO8R8rkyg+dYswqgEE=; b=hz64i/bK4NPqQ1HD5uExJbi77tKoMFMINK2gRQ0hFEhC5g7bjrym1qr70d1C9loLuk E+zhyTh0+tABAbdU7FgUwoL0xIVjgq8kFzG3EJWs+eskgp0H/aSNivY8h+oj62ft7QU6 Fue8riBNkVMCxhVdQLxPeBZkoAXRmUjaEThC9FwaBifWS901pweJpDSV858bAstgJl2R n/EeSne+Rmy90R1XzxByOJMWqhIWCjLxCMP3b9ucKX3DBJdtTqmrL+3QNRpnWsknfRvz ByhK43huweolelg0MHEq2hzn8s6tinsPW9kFLL3VaUlEROj1PEAtmoLZmb/7b1dldll1 lqdQ== X-Gm-Message-State: ANoB5pn3jpsv2ySdX5A/X8aKFZ45KnIGC9LH1APistuArEsPRBbGITbW tFUbVfOkb36sGIF5An5ZZn0tRw== X-Google-Smtp-Source: AA0mqf7lZaeE4yg7AW0Zyy+PHMsdV0xTaeowycIugKV0CyHIEnPfVIYVEXLDovr2cbvx7/bzEry1XA== X-Received: by 2002:a17:903:40c4:b0:188:4f86:e4ea with SMTP id t4-20020a17090340c400b001884f86e4eamr18503460pld.59.1669369723802; Fri, 25 Nov 2022 01:48:43 -0800 (PST) Received: from ?IPV6:2400:4050:c360:8200:8ae8:3c4:c0da:7419? ([2400:4050:c360:8200:8ae8:3c4:c0da:7419]) by smtp.gmail.com with ESMTPSA id r17-20020a63ce51000000b0045751ef6423sm2273887pgi.87.2022.11.25.01.48.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 01:48:43 -0800 (PST) Message-ID: <4a2d4e3e-5b15-2c58-dc49-92908ab80ad0@daynix.com> Date: Fri, 25 Nov 2022 18:48:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Maciej Fijalkowski References: <20221123010926.7924-1-akihiko.odaki@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fh9lKt/Ex1PEWTAeH6nLeKPXEkO8R8rkyg+dYswqgEE=; b=vDysZeeLfQomwf6B75nRI+HaGjwrhHZIUs5fdZIrRPKP/VbWvL7yQ0ALrxn4dZl7j9 n+kpaP41Wst0rPmTeoFnCi1nUcqjnbvqBwdn69zyBwUV/DX4wxKIvJ/vlrfJ8V/DUNmg Je7abb6o1fqWw+0Owl7vUd5QNv/AEvpp0VaHOT+SOBNUcA8KkJzgDrlQyWWRtEjH6YMb id+oeuDWgcYSLAEolbcBqs864ZePbxbPDZZmCwSYUqNYf8Dqrw1ah3nxPAIp87+ybaEc OMNm7FyX6fB7gDrl5TTgsNRtySjRrC+DRrN1m5r/w9nqR06/zETDgWY+DnOLP/hj/z9L dRJg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=daynix-com.20210112.gappssmtp.com header.i=@daynix-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=vDysZeeL Subject: Re: [Intel-wired-lan] [PATCH v3] igb: Allocate MSI-X vector when testing X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yuri Benditovich , Eric Dumazet , Jakub Kicinski , Yan Vugenfirer , intel-wired-lan@lists.osuosl.org, Paolo Abeni , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2022/11/24 0:41, Maciej Fijalkowski wrote: > On Wed, Nov 23, 2022 at 10:09:26AM +0900, Akihiko Odaki wrote: >> Without this change, the interrupt test fail with MSI-X environment: >> >> $ sudo ethtool -t enp0s2 offline >> [ 43.921783] igb 0000:00:02.0: offline testing starting >> [ 44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down >> [ 44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> [ 51.272202] igb 0000:00:02.0: testing shared interrupt >> [ 56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> The test result is FAIL >> The test extra info: >> Register test (offline) 0 >> Eeprom test (offline) 0 >> Interrupt test (offline) 4 >> Loopback test (offline) 0 >> Link test (on/offline) 0 >> >> Here, "4" means an expected interrupt was not delivered. >> >> To fix this, route IRQs correctly to the first MSI-X vector by setting >> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be >> masked. The interrupt test now runs properly with this change: > > Much better! > >> >> $ sudo ethtool -t enp0s2 offline >> [ 42.762985] igb 0000:00:02.0: offline testing starting >> [ 50.141967] igb 0000:00:02.0: testing shared interrupt >> [ 56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> The test result is PASS >> The test extra info: >> Register test (offline) 0 >> Eeprom test (offline) 0 >> Interrupt test (offline) 0 >> Loopback test (offline) 0 >> Link test (on/offline) 0 >> >> Signed-off-by: Akihiko Odaki > > Same comment as on other patch - justify why there is no fixes tag and > specify the tree in subject. I couldn't identify what commit introduced the problem. Please see: https://lore.kernel.org/netdev/f2457229-865a-57a0-94a1-c5c63b2f30a5@daynix.com/ Regards, Akihiko Odaki > >> --- >> drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> index e5f3e7680dc6..ff911af16a4b 100644 >> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c >> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data) >> *data = 1; >> return -1; >> } >> + wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8); >> + wr32(E1000_EIMS, BIT(0)); >> } else if (adapter->flags & IGB_FLAG_HAS_MSI) { >> shared_int = false; >> if (request_irq(irq, >> -- >> 2.38.1 >> _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3C8C4332F for ; Fri, 25 Nov 2022 09:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiKYJvc (ORCPT ); Fri, 25 Nov 2022 04:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbiKYJvP (ORCPT ); Fri, 25 Nov 2022 04:51:15 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA7546677 for ; Fri, 25 Nov 2022 01:48:44 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so7225782pjc.3 for ; Fri, 25 Nov 2022 01:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fh9lKt/Ex1PEWTAeH6nLeKPXEkO8R8rkyg+dYswqgEE=; b=vDysZeeLfQomwf6B75nRI+HaGjwrhHZIUs5fdZIrRPKP/VbWvL7yQ0ALrxn4dZl7j9 n+kpaP41Wst0rPmTeoFnCi1nUcqjnbvqBwdn69zyBwUV/DX4wxKIvJ/vlrfJ8V/DUNmg Je7abb6o1fqWw+0Owl7vUd5QNv/AEvpp0VaHOT+SOBNUcA8KkJzgDrlQyWWRtEjH6YMb id+oeuDWgcYSLAEolbcBqs864ZePbxbPDZZmCwSYUqNYf8Dqrw1ah3nxPAIp87+ybaEc OMNm7FyX6fB7gDrl5TTgsNRtySjRrC+DRrN1m5r/w9nqR06/zETDgWY+DnOLP/hj/z9L dRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fh9lKt/Ex1PEWTAeH6nLeKPXEkO8R8rkyg+dYswqgEE=; b=bHO9fYeLpu6iESejqwzWBzTs6dvNk7Ljmfh2PoGsT6ir2wUw5q2r2vWZ6ATjOXJR3d 2nNWdRGvVMi0ktx8VbcPAEWpypE73ZBTSaOGw8WtnMDKam2orJOhp/BEEu8I5zHzyngX 9wqfv9jN7C5S0ihlBGPiAt92ONotQULRxuwnhBerHUdA0r4EZY1vEDGZU4bMYwpDn8n1 VKgTmT9jarxWROwQEDVC8axSkki38qeQb8vEWWfuuX/JU6JDkVCraqFTaeAZ9NMYjYsr XyU4qT7vsRfSI8T7bgPevyXHO4Yu5xyv7keUk99JHJhan3J3LfhACuX8GmMF1LllFtaN P+kQ== X-Gm-Message-State: ANoB5pk9Xt6l4XXDeJ3jxikNxpSAYwI7SOS2QXHt/t6RKOYdIpawzbgD 99adEXewGHHbd9FgCR6f1mFDBg== X-Google-Smtp-Source: AA0mqf7lZaeE4yg7AW0Zyy+PHMsdV0xTaeowycIugKV0CyHIEnPfVIYVEXLDovr2cbvx7/bzEry1XA== X-Received: by 2002:a17:903:40c4:b0:188:4f86:e4ea with SMTP id t4-20020a17090340c400b001884f86e4eamr18503460pld.59.1669369723802; Fri, 25 Nov 2022 01:48:43 -0800 (PST) Received: from ?IPV6:2400:4050:c360:8200:8ae8:3c4:c0da:7419? ([2400:4050:c360:8200:8ae8:3c4:c0da:7419]) by smtp.gmail.com with ESMTPSA id r17-20020a63ce51000000b0045751ef6423sm2273887pgi.87.2022.11.25.01.48.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 01:48:43 -0800 (PST) Message-ID: <4a2d4e3e-5b15-2c58-dc49-92908ab80ad0@daynix.com> Date: Fri, 25 Nov 2022 18:48:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3] igb: Allocate MSI-X vector when testing To: Maciej Fijalkowski Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yan Vugenfirer , Yuri Benditovich References: <20221123010926.7924-1-akihiko.odaki@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/24 0:41, Maciej Fijalkowski wrote: > On Wed, Nov 23, 2022 at 10:09:26AM +0900, Akihiko Odaki wrote: >> Without this change, the interrupt test fail with MSI-X environment: >> >> $ sudo ethtool -t enp0s2 offline >> [ 43.921783] igb 0000:00:02.0: offline testing starting >> [ 44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down >> [ 44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> [ 51.272202] igb 0000:00:02.0: testing shared interrupt >> [ 56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> The test result is FAIL >> The test extra info: >> Register test (offline) 0 >> Eeprom test (offline) 0 >> Interrupt test (offline) 4 >> Loopback test (offline) 0 >> Link test (on/offline) 0 >> >> Here, "4" means an expected interrupt was not delivered. >> >> To fix this, route IRQs correctly to the first MSI-X vector by setting >> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be >> masked. The interrupt test now runs properly with this change: > > Much better! > >> >> $ sudo ethtool -t enp0s2 offline >> [ 42.762985] igb 0000:00:02.0: offline testing starting >> [ 50.141967] igb 0000:00:02.0: testing shared interrupt >> [ 56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX >> The test result is PASS >> The test extra info: >> Register test (offline) 0 >> Eeprom test (offline) 0 >> Interrupt test (offline) 0 >> Loopback test (offline) 0 >> Link test (on/offline) 0 >> >> Signed-off-by: Akihiko Odaki > > Same comment as on other patch - justify why there is no fixes tag and > specify the tree in subject. I couldn't identify what commit introduced the problem. Please see: https://lore.kernel.org/netdev/f2457229-865a-57a0-94a1-c5c63b2f30a5@daynix.com/ Regards, Akihiko Odaki > >> --- >> drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> index e5f3e7680dc6..ff911af16a4b 100644 >> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c >> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data) >> *data = 1; >> return -1; >> } >> + wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8); >> + wr32(E1000_EIMS, BIT(0)); >> } else if (adapter->flags & IGB_FLAG_HAS_MSI) { >> shared_int = false; >> if (request_irq(irq, >> -- >> 2.38.1 >>