From: Kunwu Chan <kunwu.chan@linux.dev>
To: Mostafa Saleh <smostafa@google.com>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: arm64: Dump instruction on hyp panic
Date: Thu, 31 Jul 2025 20:58:44 +0800 [thread overview]
Message-ID: <4a807c89-d57b-463a-9166-836301ee9947@linux.dev> (raw)
In-Reply-To: <20250717234744.2254371-2-smostafa@google.com>
Hi Mostafa,
On 2025/7/18 07:47, Mostafa Saleh wrote:
... ....
> + /* Dump the faulting instruction */
> + if (!is_protected_kvm_enabled() ||
> + IS_ENABLED(CONFIG_NVHE_EL2_DEBUG))
> + dump_instr(panic_addr + kaslr_offset());
> +
This part seem like unnecessary, cause it'll be remove in patch 2(Only
the comment left).
> /*
> * Hyp has panicked and we're going to handle that by panicking the
> * kernel. The kernel offset will be revealed in the panic so we're
Another confusion is that no similar wording to what you mentioned in
the cover—specifically "Cannot dump pKVM nVHE stacktrace:
!CONFIG_PROTECTED_NVHE_STACKTRACE"—has been found in the code.
--
Thanks,
Kunwu Chan.
next prev parent reply other threads:[~2025-07-31 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 23:47 [PATCH 0/2] Dump instructions on panic for pKVM/nvhe Mostafa Saleh
2025-07-17 23:47 ` [PATCH 1/2] KVM: arm64: Dump instruction on hyp panic Mostafa Saleh
2025-07-31 12:58 ` Kunwu Chan [this message]
2025-07-31 13:05 ` Mostafa Saleh
2025-08-01 8:00 ` Kunwu Chan
2025-09-08 12:16 ` Will Deacon
2025-09-09 13:10 ` Mostafa Saleh
2025-07-17 23:47 ` [PATCH 2/2] KVM: arm64: Map hyp text as RO and dump instr on panic Mostafa Saleh
2025-07-18 10:16 ` Ben Horgan
2025-07-18 10:22 ` Mostafa Saleh
2025-07-18 10:35 ` Ben Horgan
2025-09-08 12:11 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a807c89-d57b-463a-9166-836301ee9947@linux.dev \
--to=kunwu.chan@linux.dev \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.