Re: [PATCH] platform/x86: asus-wmi: map more keys on ExpertBook B9

[Hans de Goede <hansg@kernel.org>]

Hi,

On 2-Jul-25 09:02, Anton Khirnov wrote:
> * there is a dedicated "noise cancel" key in top row, between mic mute
>   and PrintScreen; it sends 0xCA when pressed by itself (mapped to F14),
>   0xCB with Fn (mapped to F15)
> * Fn+f sends 0x9D; it is not documented in the manual, but some web
>   search results mention "asus intelligent performance"; mapped to PROG2
> * Fn+space sends 0x5B; it is not documented or mentioned anywhere I
>   could find; mapped to PROG3
> 
> Signed-off-by: Anton Khirnov <anton@khirnov.net>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 3f8b2a324efd..42d7b435ba63 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -573,6 +573,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x55, { KEY_CALC } },
>  	{ KE_IGNORE, 0x57, },  /* Battery mode */
>  	{ KE_IGNORE, 0x58, },  /* AC mode */
> +	{ KE_KEY, 0x5B, { KEY_PROG3 } }, /* Fn+space */

What is this key-combo supposed to do, is there any icon for this on
the spacebar? What does it do under Windows?

Based on other laptops I would expect this to maybe need to be
KEY_KBDILLUMTOGGLE, which toggles the kbd backlight on/off ?

>  	{ KE_KEY, 0x5C, { KEY_F15 } },  /* Power Gear key */

Why KEY_F15, Why not some other KEY_ ? Generally speaking
the key-code send should match the intended purpose of
they key / key-combo. E.g. If the button opens
the control-panel under Windows use KEY_CONTROLPANEL

>  	{ KE_KEY, 0x5D, { KEY_WLAN } }, /* Wireless console Toggle */
>  	{ KE_KEY, 0x5E, { KEY_WLAN } }, /* Wireless console Enable */
> @@ -609,6 +610,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x93, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + DVI */
>  	{ KE_KEY, 0x95, { KEY_MEDIA } },
>  	{ KE_KEY, 0x99, { KEY_PHONE } }, /* Conflicts with fan mode switch */
> +	{ KE_KEY, 0X9D, { KEY_PROG2 } }, /* Fn+f */

Same remark as on the other keys. what does this do under Windows ?

>  	{ KE_KEY, 0xA0, { KEY_SWITCHVIDEOMODE } }, /* SDSP HDMI only */
>  	{ KE_KEY, 0xA1, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + HDMI */
>  	{ KE_KEY, 0xA2, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + HDMI */
> @@ -623,6 +625,8 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_IGNORE, 0xC0, }, /* External display connect/disconnect notification */
>  	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>  	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
> +	{ KE_KEY, 0xCA, { KEY_F14 } }, /* Noise cancelling on Expertbook B9 */

KEY_SOUND ?

> +	{ KE_KEY, 0xCB, { KEY_F15 } }, /* Fn+noise-cancel */

What does Fn + noise-cancel do under Windows ?

>  	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
>  	{ KE_IGNORE, 0xCF, },	/* AC mode */
>  	{ KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */


Regards,

Hans