From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FC1C6FD1F for ; Fri, 17 Mar 2023 00:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbjCQAbj (ORCPT ); Thu, 16 Mar 2023 20:31:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjCQAbi (ORCPT ); Thu, 16 Mar 2023 20:31:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D1D68090B; Thu, 16 Mar 2023 17:31:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC9C36215A; Fri, 17 Mar 2023 00:31:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CB99C433EF; Fri, 17 Mar 2023 00:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679013076; bh=Nhpqn/sIr/rBSfz125kjIVwRa7eO52ZCanweMIXsACs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=t99MJSpQjkHLLinT2SDWYyww8YndV1+LNMc1y6rcb/ITB4wOs/v9wAxspC/xsfoRL qowGVw3MIFrIxYU+gSIGNyWvCsTkXhdIuPCONp1/giHLQRYRzuRe/7GrHWTgy4dJCb uOjjHdjM8zmVM38MlElxzj9iCr1d1PO9lD9e+zhGV6vjDLhqF9Zz2txeoWEiN0PZ2M ffcMrCIbx/D5HvDCNY3l7dibKAgd+ExyGrMM+gG+AWYu2cVZ/SXTmEd4A28m+nln1E JJdrgyQe2U3t19uOg21vNe7D6RxgCaaFeBz1nU71rFIeQmpxikB7/HrMncmBZd/k4a 51g6hP5lmL2bA== Message-ID: <4a9b2ed78ed80c15bb8089e2fccaf1b3.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230316154850.wxwiztump5de3xt4@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> <20230316150144.2aap5otmgblj24ty@bogus> <20230316154850.wxwiztump5de3xt4@pengutronix.de> Subject: Re: [PATCH 15/30] clk: scpi: Convert to platform remove callback returning void From: Stephen Boyd Cc: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Michael Turquette , Sudeep Holla , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Thu, 16 Mar 2023 17:31:14 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-16 08:48:50) > Hello, >=20 > [put the clk maintainers in To:] >=20 > On Thu, Mar 16, 2023 at 03:01:44PM +0000, Sudeep Holla wrote: > > On Sun, Mar 12, 2023 at 05:14:57PM +0100, Uwe Kleine-K=EF=BF=BDnig wrot= e: > > > The .remove() callback for a platform driver returns an int which mak= es > > > many driver authors wrongly assume it's possible to do error handling= by > > > returning an error code. However the value returned is (mostly) ignor= ed > > > and this typically results in resource leaks. To improve here there i= s a > > > quest to make the remove callback return void. In the first step of t= his > > > quest all drivers are converted to .remove_new() which already returns > > > void. > > >=20 > > > Trivially convert this driver from always returning zero in the remove > > > callback to the void returning variant. > > > > >=20 > > Acked-by: Sudeep Holla > >=20 > > Let me know if you want me to pick up instead. >=20 > Honestly I don't know. I expected that the series is applied completely > via the clk maintainers, but the samsung patch was already taken > individually. >=20 > Michael and Stephen: It would probably be helpful if you shared your > thoughs about this. For me both options are fine. >=20 I will pick up whatever isn't picked by SoC maintainers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B052EC6FD1F for ; Fri, 17 Mar 2023 00:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dbDcmdSAhoprPUP+xmNTKK0CjVw25eZDyqlmVa6k2+g=; b=WCRiZvqoJGgiTH Xe6v5/PregnQY5c2oh3IgG92Ygy1gra+v+H5avpxjV0ItSCldRpevDHZgHw13kS7ytj5ipH7ltVSH Hsi9mqNBdDvS+vihHv5UnBHaQN5ar6590oZzItXh1Bv0LaM6wS+PeiqdJXsFqNVHybX1H6RS3m2qX t+2EZ1mp5/EGpIX+MRSpUn2deAHjsHYM6KsfblAVZ2T4mT7cIoFHSlB/ob268JZBrMRnpaSRtv/Qz 5pe00e9nR88ifBqoTla+FpwxVZFl1li17qjn0oqX0PhyAjeUgxgMW8i66ny8MDkhCQCGnvFxgXdIX t7IyO6cfDU+L+wD2cYEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcy0B-000S0I-0e; Fri, 17 Mar 2023 00:31:23 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcy08-000RzQ-1g for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 00:31:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C9042CE1DB0; Fri, 17 Mar 2023 00:31:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CB99C433EF; Fri, 17 Mar 2023 00:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679013076; bh=Nhpqn/sIr/rBSfz125kjIVwRa7eO52ZCanweMIXsACs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=t99MJSpQjkHLLinT2SDWYyww8YndV1+LNMc1y6rcb/ITB4wOs/v9wAxspC/xsfoRL qowGVw3MIFrIxYU+gSIGNyWvCsTkXhdIuPCONp1/giHLQRYRzuRe/7GrHWTgy4dJCb uOjjHdjM8zmVM38MlElxzj9iCr1d1PO9lD9e+zhGV6vjDLhqF9Zz2txeoWEiN0PZ2M ffcMrCIbx/D5HvDCNY3l7dibKAgd+ExyGrMM+gG+AWYu2cVZ/SXTmEd4A28m+nln1E JJdrgyQe2U3t19uOg21vNe7D6RxgCaaFeBz1nU71rFIeQmpxikB7/HrMncmBZd/k4a 51g6hP5lmL2bA== Message-ID: <4a9b2ed78ed80c15bb8089e2fccaf1b3.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230316154850.wxwiztump5de3xt4@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> <20230316150144.2aap5otmgblj24ty@bogus> <20230316154850.wxwiztump5de3xt4@pengutronix.de> Subject: Re: [PATCH 15/30] clk: scpi: Convert to platform remove callback returning void From: Stephen Boyd Cc: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Michael Turquette , Sudeep Holla , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Thu, 16 Mar 2023 17:31:14 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_173120_727446_53D0B05F X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBVd2UgS2xlaW5lLUvDtm5pZyAoMjAyMy0wMy0xNiAwODo0ODo1MCkKPiBIZWxsbywK PiAKPiBbcHV0IHRoZSBjbGsgbWFpbnRhaW5lcnMgaW4gVG86XQo+IAo+IE9uIFRodSwgTWFyIDE2 LCAyMDIzIGF0IDAzOjAxOjQ0UE0gKzAwMDAsIFN1ZGVlcCBIb2xsYSB3cm90ZToKPiA+IE9uIFN1 biwgTWFyIDEyLCAyMDIzIGF0IDA1OjE0OjU3UE0gKzAxMDAsIFV3ZSBLbGVpbmUtS++/vW5pZyB3 cm90ZToKPiA+ID4gVGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIg cmV0dXJucyBhbiBpbnQgd2hpY2ggbWFrZXMKPiA+ID4gbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9u Z2x5IGFzc3VtZSBpdCdzIHBvc3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5Cj4gPiA+IHJl dHVybmluZyBhbiBlcnJvciBjb2RlLiBIb3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9z dGx5KSBpZ25vcmVkCj4gPiA+IGFuZCB0aGlzIHR5cGljYWxseSByZXN1bHRzIGluIHJlc291cmNl IGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUgaXMgYQo+ID4gPiBxdWVzdCB0byBtYWtlIHRo ZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRoZSBmaXJzdCBzdGVwIG9mIHRoaXMK PiA+ID4gcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAucmVtb3ZlX25ldygpIHdo aWNoIGFscmVhZHkgcmV0dXJucwo+ID4gPiB2b2lkLgo+ID4gPiAKPiA+ID4gVHJpdmlhbGx5IGNv bnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92 ZQo+ID4gPiBjYWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KPiA+ID4KPiA+ IAo+ID4gQWNrZWQtYnk6IFN1ZGVlcCBIb2xsYSA8c3VkZWVwLmhvbGxhQGFybS5jb20+Cj4gPiAK PiA+IExldCBtZSBrbm93IGlmIHlvdSB3YW50IG1lIHRvIHBpY2sgdXAgaW5zdGVhZC4KPiAKPiBI b25lc3RseSBJIGRvbid0IGtub3cuIEkgZXhwZWN0ZWQgdGhhdCB0aGUgc2VyaWVzIGlzIGFwcGxp ZWQgY29tcGxldGVseQo+IHZpYSB0aGUgY2xrIG1haW50YWluZXJzLCBidXQgdGhlIHNhbXN1bmcg cGF0Y2ggd2FzIGFscmVhZHkgdGFrZW4KPiBpbmRpdmlkdWFsbHkuCj4gCj4gTWljaGFlbCBhbmQg U3RlcGhlbjogSXQgd291bGQgcHJvYmFibHkgYmUgaGVscGZ1bCBpZiB5b3Ugc2hhcmVkIHlvdXIK PiB0aG91Z2hzIGFib3V0IHRoaXMuIEZvciBtZSBib3RoIG9wdGlvbnMgYXJlIGZpbmUuCj4gCgpJ IHdpbGwgcGljayB1cCB3aGF0ZXZlciBpc24ndCBwaWNrZWQgYnkgU29DIG1haW50YWluZXJzLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=