From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A95A0E77188 for ; Wed, 8 Jan 2025 20:10:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVcNZ-0003cU-SF; Wed, 08 Jan 2025 15:10:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVcNX-0003c7-Fn for qemu-devel@nongnu.org; Wed, 08 Jan 2025 15:10:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVcNV-0002re-37 for qemu-devel@nongnu.org; Wed, 08 Jan 2025 15:10:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736367005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JIP+8rA2zUFRWT4YG503h4lybZmywnEkgMNxUI/bs3Q=; b=KZqxq5elk95GFeW1Nmi2DmMPB9WEr9rokZatMC0MAYdb3SHJwLU83zAZ+JtjuBymnu5t7T 3btDcbDZnGjZiTYs4lASl3FqNQPk6Lds3SwKI63XkDgeeTHFyWViFwkjCOK+O9GhgP7ddg /k0aCOrlQurmjbM0QYe4PGfw9YARtoM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-1dyDwzuuMWiR2CpjfMxH6A-1; Wed, 08 Jan 2025 15:10:04 -0500 X-MC-Unique: 1dyDwzuuMWiR2CpjfMxH6A-1 X-Mimecast-MFC-AGG-ID: 1dyDwzuuMWiR2CpjfMxH6A Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38a684a0971so59989f8f.2 for ; Wed, 08 Jan 2025 12:10:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736367003; x=1736971803; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JIP+8rA2zUFRWT4YG503h4lybZmywnEkgMNxUI/bs3Q=; b=Qrpo66aSZt2x1X49GLRM3CLbzawBaXHa8wMNSDnTS+qmESjk7keBkn9GXnhb/FfHmm X6f09i3hteiKlN5CiUMkCguaTYKhSp45f0EEZE1iuR4hASga3qjjPJ6E+qqXBizIw63h VghGr0bIsAr4Oqi0g5am8SBcq5bIk7qEQYQ3LVZqKJ4Z+EYvDktdRDyAU4TdM1ba1EPd 7d9R7Cv+U/vWFwHTvuQv35P3VF+1XQLDQkm/Oo0Ffh0Ucl8HNCC1jf3nPCaJ8YhSdVdq cehuY8TnUi8QHn5zDVNKCEOMMQ2uDSZ6W5SF1dUQKrQhJ9vQPxAmECHA4rBnpbgob0IC 3ISQ== X-Forwarded-Encrypted: i=1; AJvYcCUY3YTmsOgVl7cUsSZp/Bv3pnHshn4W3k36qm04JE+lUjMo7oGQGKzR4s6G3Oo+e/npW8RpI44GIZ7y@nongnu.org X-Gm-Message-State: AOJu0Yy7LNCbfcteY8CfKuWzVZlEZig2wzCqd5fC/Kgx1Cxus/l6E2z9 OPVwtNSPfOuLw5wX3XqkkPh8HLsyQNRcn4HqVY21bjsj9CA3udjcaUPXNVU/hBZvNqlC1LQlxlG YOm+2pcgeGDhb8TIYnifrRNjsrjIGZ3SY+ew9SZq3Wcq8QkGtdnJZ X-Gm-Gg: ASbGnctloMkZS3hz2vREORp23HDic76GB7tFUR0fwOyLayrRrMagV3OHnKkX6N2k07N oA0m1KY5+7///3lFAXBWjgXG5wttFkHAoiWWCQKYie29MokIkic24EwHTTHPIYtqpzYuhEv42TP Jek4z7y69BV8AaysdtVepvRF2H0zrZQGABS3SfxLsqWeGCGQpcuI2sONPeHNfh2MGjZO3EMwOKG XBV9bm3SmZL44WKK0SDYBqIaNRDHPV2KAL4FBF+DsGeOdeaU/RQAotpeS9dRUBhBOlfV3q7rjTL xpGZqOcDq2Eamm3ECbDZBQfhY1qKRbh72l1wIRwg8fnVzT4O/PYVz7J4tIJPX3lM0XeQ09h+Y3o kx4vXZA== X-Received: by 2002:a05:6000:1849:b0:386:2ebe:7ae2 with SMTP id ffacd0b85a97d-38a8733df9emr4088918f8f.45.1736367002748; Wed, 08 Jan 2025 12:10:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyFrdMwKnQAiyNaJKhjjkwNlTtkSIvJyL3vPjd38LWMQ75yQu5MT7GV40wtlSziOXA4cHwbw== X-Received: by 2002:a05:6000:1849:b0:386:2ebe:7ae2 with SMTP id ffacd0b85a97d-38a8733df9emr4088883f8f.45.1736367002323; Wed, 08 Jan 2025 12:10:02 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7? (p200300cbc70d3a00d73c06a8ca9f1df7.dip0.t-ipconnect.de. [2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8475cesm53380296f8f.57.2025.01.08.12.09.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 12:10:01 -0800 (PST) Message-ID: <4aa676ea-331f-4c8b-be1d-208804ede674@redhat.com> Date: Wed, 8 Jan 2025 21:09:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] physmem: allow cpu_memory_rw_debug to write to MMIO devices To: Stefan Zabka , qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell , Richard Henderson References: <20241220195923.314208-1-git@zabka.it> <44f99f89-edb6-4007-a367-f7f3b9e10b7b@zabka.it> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.432, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 08.01.25 19:35, Stefan Zabka wrote: > On 21/12/2024 15:55, David Hildenbrand wrote: > > Let's wait for opinions from others first. > > > states that two weeks is a reasonable amount of time for follow-up. > > Should I also ping the original patch? I thought pinging the thread > would be more appropriate, as it contains relevant information. > I just pushed a compiling version of the attrs.debug approach to: https://github.com/davidhildenbrand/qemu/tree/debug_access With two preparation patches, the relevant patch is: From 2e85cb1724385e4b8640364415832c030e5c5e6d Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Wed, 8 Jan 2025 20:58:00 +0100 Subject: [PATCH] physmem: allow cpu_memory_rw_debug to write to MMIO devices Signed-off-by: David Hildenbrand --- hw/core/cpu-sysemu.c | 13 +++++++++---- include/exec/memattrs.h | 5 ++++- include/exec/memory.h | 2 ++ system/physmem.c | 9 ++------- 4 files changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/core/cpu-sysemu.c b/hw/core/cpu-sysemu.c index 2a9a2a4eb5..0aa0a569e4 100644 --- a/hw/core/cpu-sysemu.c +++ b/hw/core/cpu-sysemu.c @@ -51,13 +51,18 @@ hwaddr cpu_get_phys_page_attrs_debug(CPUState *cpu, vaddr addr, MemTxAttrs *attrs) { CPUClass *cc = CPU_GET_CLASS(cpu); + hwaddr paddr; if (cc->sysemu_ops->get_phys_page_attrs_debug) { - return cc->sysemu_ops->get_phys_page_attrs_debug(cpu, addr, attrs); + paddr = cc->sysemu_ops->get_phys_page_attrs_debug(cpu, addr, attrs); + } else { + /* Fallback for CPUs which don't implement the _attrs_ hook */ + *attrs = MEMTXATTRS_UNSPECIFIED; + paddr = cc->sysemu_ops->get_phys_page_debug(cpu, addr); } - /* Fallback for CPUs which don't implement the _attrs_ hook */ - *attrs = MEMTXATTRS_UNSPECIFIED; - return cc->sysemu_ops->get_phys_page_debug(cpu, addr); + /* Indicate that this is a debug access. */ + attrs->debug = 1; + return paddr; } hwaddr cpu_get_phys_page_debug(CPUState *cpu, vaddr addr) diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h index e27c18f3dc..14e0edaa58 100644 --- a/include/exec/memattrs.h +++ b/include/exec/memattrs.h @@ -26,7 +26,8 @@ typedef struct MemTxAttrs { /* Bus masters which don't specify any attributes will get this * (via the MEMTXATTRS_UNSPECIFIED constant), so that we can * distinguish "all attributes deliberately clear" from - * "didn't specify" if necessary. + * "didn't specify" if necessary. "debug" can be set alongside + * "unspecified". */ unsigned int unspecified:1; /* @@ -50,6 +51,8 @@ typedef struct MemTxAttrs { * (see MEMTX_ACCESS_ERROR). */ unsigned int memory:1; + /* Debug access that can even write to ROM. */ + unsigned int debug:1; /* Requester ID (for MSI for example) */ unsigned int requester_id:16; diff --git a/include/exec/memory.h b/include/exec/memory.h index 3dcadcf3a2..7458082455 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -2990,6 +2990,8 @@ static inline bool memory_access_is_direct(MemoryRegion *mr, bool is_write, MemTxAttrs attrs) { if (is_write) { + if (attrs.debug) + return memory_region_is_ram(mr) || memory_region_is_romd(mr); return memory_region_is_ram(mr) && !mr->readonly && !mr->rom_device && !memory_region_is_ram_device(mr); } else { diff --git a/system/physmem.c b/system/physmem.c index 3c2a0b0289..03d3618039 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3573,13 +3573,8 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr, if (l > len) l = len; phys_addr += (addr & ~TARGET_PAGE_MASK); - if (is_write) { - res = address_space_write_rom(cpu->cpu_ases[asidx].as, phys_addr, - attrs, buf, l); - } else { - res = address_space_read(cpu->cpu_ases[asidx].as, phys_addr, - attrs, buf, l); - } + res = address_space_rw(cpu->cpu_ases[asidx].as, phys_addr, attrs, buf, + l, is_write); if (res != MEMTX_OK) { return -1; } -- 2.47.1 You could could give that a churn if that solves your issue as well. Let me CC more people that might have an opinion on how it should be done. -- Cheers, David / dhildenb