From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from azure-sdnproxy.icoremail.net (l-sdnproxy.icoremail.net [20.188.111.126]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1086C239E8B; Fri, 29 Aug 2025 06:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=20.188.111.126 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448560; cv=none; b=u0dZdMhVSYK+60loNLKo2u/nrxE4Xl0wn7tiREnIpxtlBs9rirHJbZ7fAJsCrUUgfAWATDyBTQ6hOOU2K/kvvX8pSrd5UCYUkkncJwYsnvLRPwWQBoh/O5zi/c95lqYWYMRrZEE9xPx6Qxozv9zJ8mJm477Gr3WPfUbDN5lCTrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448560; c=relaxed/simple; bh=lWKeDfUs6UcJqhbuIh8nb+LFfX5MhFTkvtJkcRl9h9o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type: MIME-Version:Message-ID; b=Gwm71nGIOO1ErURK1pyJQlFe8Tn5va6soY1HKxUNSgw63L5O9p9w42GeAfqdH1QSGv2uTbQVeXB9i4c+19crDtvY3X8brE6/kMZDHKz2zxElDz1S6hLvxQWo93ojs4wZSCwN1diy2nhwDn5mt4rK9I2xIcBOyRnx7+jBFN4bwA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com; spf=pass smtp.mailfrom=eswincomputing.com; arc=none smtp.client-ip=20.188.111.126 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from luyulin$eswincomputing.com ( [10.12.96.77] ) by ajax-webmail-app2 (Coremail) ; Fri, 29 Aug 2025 14:22:11 +0800 (GMT+08:00) Date: Fri, 29 Aug 2025 14:22:11 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: luyulin@eswincomputing.com To: "Niklas Cassel" Cc: "Rob Herring" , dlemoal@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, ningyu@eswincomputing.com, zhengyu@eswincomputing.com, linmin@eswincomputing.com, huangyifeng@eswincomputing.com, fenglin@eswincomputing.com, lianghujun@eswincomputing.com Subject: Re: Re: Re: [PATCH v2 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2024.2-cmXT6 build 20241203(6b039d88) Copyright (c) 2002-2025 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: References: <20250819134722.220-1-luyulin@eswincomputing.com> <20250819135413.386-1-luyulin@eswincomputing.com> <692e11ca.843.198f0337528.Coremail.luyulin@eswincomputing.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <4ab70c6a.8be.198f47da494.Coremail.luyulin@eswincomputing.com> X-Coremail-Locale: zh_CN X-CM-TRANSID:TQJkCgDHZpUTR7Foff_EAA--.23769W X-CM-SenderInfo: pox13z1lq6v25zlqu0xpsx3x1qjou0bp/1tbiAgEJA2iwhNAS7QAA s6 X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Cj4gT24gVGh1LCBBdWcgMjgsIDIwMjUgYXQgMDY6MjI6NDBQTSArMDgwMCwgbHV5dWxpbkBlc3dp bmNvbXB1dGluZy5jb20gd3JvdGU6Cj4gPiAKPiA+IERvIHlvdSBtZWFuIHRoYXQgcG9ydHMtaW1w bGVtZW50ZWQgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgZHRzLAo+ID4gYW5kIHRoZSBjb3Jy ZXNwb25kaW5nIHJlZ2lzdGVyIHNob3VsZCBiZSBjb25maWd1cmVkIGJ5IHRoZSBmaXJtd2FyZQo+ ID4gKHdoaWNoIGlzIFUtQm9vdCBvbiB0aGUgSGlGaXZlIFByZW1pZXIgUDU1MCBib2FyZCk/IElz IHRoaXMgdW5kZXJzdGFuZGluZyBjb3JyZWN0Pwo+ID4gSWYgc28sIHdoZW4gdGhlIGRyaXZlciBp cyByZW1vdmVkLCBhIHJlc2V0IHdpbGwgYmUgdHJpZ2dlcmVkLAo+ID4gY2F1c2luZyB0aGUgY29u ZmlndXJhdGlvbiBvZiB0aGlzIHJlZ2lzdGVyIHRvIGJlIGxvc3QsCj4gPiB3aGljaCB3aWxsIHJl c3VsdCBpbiBhbiBlcnJvciB3aGVuIGluc21vZCB0aGUgZHJpdmVyIGFnYWluLgo+IAo+IE15IDUw IGNlbnRzLAo+IAo+IGlmIHRoZSBwb3J0cyBpbXBsZW1lbnRlZCByZWdpc3RlciBnZXRzIHJlc2V0 IGZyb20gdGhlIHJlc2V0X2NvbnRyb2xfcmVzZXQoKQo+IGluIGFoY2lfcGxhdGZvcm1fYXNzZXJ0 X3JzdHMoKSwgdGhlbiBpdCBzZWVtcyBsaWtlIGhhdmluZyBwb3J0cy1pbXBsZW1lbnRlZAo+IGlu IGRldmljZSB0cmVlIGlzIGFjY2VwdGFibGUuCj4gCgpJbiBvdXIgZGVzaWduLCB0aGUgcG9ydHMg aW1wbGVtZW50ZWQgcmVnaXN0ZXIgZ2V0cyByZXNldCBmcm9tIHRoZSBhaGNpX3BsYXRmb3JtX2Fz c2VydF9yc3RzKCkuCgo+IFRoZXJlIGFyZSBhIGJ1bmNoIG9mIGRldmljZSB0cmVlcyB0aGF0IGhh dmUgdGhpcyBhbHJlYWR5Ogo+IGFyY2gvYXJtL2Jvb3QvZHRzL3Fjb20vcWNvbS1hcHE4MDY0LmR0 c2k6ICAgICAgICAgICAgICAgICAgICAgICBwb3J0cy1pbXBsZW1lbnRlZCA9IDwweDE+Owo+IGFy Y2gvYXJtL2Jvb3QvZHRzL3Fjb20vcWNvbS1pcHE4MDY0LXYxLjAuZHRzaTogICAgICAgICAgICAg ICAgICBwb3J0cy1pbXBsZW1lbnRlZCA9IDwweDE+Owo+IGFyY2gvYXJtL2Jvb3QvZHRzL3Fjb20v cWNvbS1pcHE4MDY0LXYyLjAuZHRzaTogIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJj aC9hcm0vYm9vdC9kdHMvc2Ftc3VuZy9leHlub3M1MjUwLmR0c2k6ICAgICAgICAgICAgICAgICAg ICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJjaC9hcm0vYm9vdC9kdHMvc29jaW9u ZXh0L3VuaXBoaWVyLXBybzQuZHRzaTogICAgICAgICAgICAgICAgIHBvcnRzLWltcGxlbWVudGVk ID0gPDE+Owo+IGFyY2gvYXJtL2Jvb3QvZHRzL3NvY2lvbmV4dC91bmlwaGllci1wcm80LmR0c2k6 ICAgICAgICAgICAgICAgICBwb3J0cy1pbXBsZW1lbnRlZCA9IDwxPjsKPiBhcmNoL2FybS9ib290 L2R0cy9zb2Npb25leHQvdW5pcGhpZXItcHhzMi5kdHNpOiAgICAgICAgICAgICAgICAgcG9ydHMt aW1wbGVtZW50ZWQgPSA8MT47Cj4gYXJjaC9hcm0vYm9vdC9kdHMvc3Qvc3RpaDQwNy1mYW1pbHku ZHRzaTogICAgICAgICAgICAgICAgICAgICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4g YXJjaC9hcm0vYm9vdC9kdHMvc3Qvc3RpaDQwNy1mYW1pbHkuZHRzaTogICAgICAgICAgICAgICAg ICAgICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJjaC9hcm0vYm9vdC9kdHMvdGkv b21hcC9kcmE3LWw0LmR0c2k6ICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRzLWltcGxlbWVu dGVkID0gPDB4MT47Cj4gYXJjaC9hcm0vYm9vdC9kdHMvdGkvb21hcC9vbWFwNS1sNC5kdHNpOiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydHMtaW1wbGVtZW50ZWQgPSA8MHgxPjsK PiBhcmNoL2FybTY0L2Jvb3QvZHRzL21lZGlhdGVrL210NzYyMi5kdHNpOiAgICAgICAgICAgICAg IHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1NjguZHRzaTogICAgICAgICAgICAgICBwb3J0cy1pbXBsZW1lbnRlZCA9IDwweDE+Owo+ IGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTZ4LWJhc2UuZHRzaTogICAgICAgICAg cG9ydHMtaW1wbGVtZW50ZWQgPSA8MHgxPjsKPiBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzU2eC1iYXNlLmR0c2k6ICAgICAgICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4g YXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NzYuZHRzaTogICAgICAgICAgICAgICAg ICAgICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazM1NzYuZHRzaTogICAgICAgICAgICAgICAgICAgICAgIHBvcnRzLWltcGxlbWVu dGVkID0gPDB4MT47Cj4gYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgtYmFzZS5k dHNpOiAgICAgICAgICBwb3J0cy1pbXBsZW1lbnRlZCA9IDwweDE+Owo+IGFyY2gvYXJtNjQvYm9v dC9kdHMvcm9ja2NoaXAvcmszNTg4LWJhc2UuZHRzaTogICAgICAgICAgcG9ydHMtaW1wbGVtZW50 ZWQgPSA8MHgxPjsKPiBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1leHRyYS5k dHNpOiAgICAgICAgIHBvcnRzLWltcGxlbWVudGVkID0gPDB4MT47Cj4gYXJjaC9hcm02NC9ib290 L2R0cy9zb2Npb25leHQvdW5pcGhpZXItcHhzMy5kdHNpOiAgICAgICAgICAgICAgICAgICAgICAg cG9ydHMtaW1wbGVtZW50ZWQgPSA8MT47Cj4gYXJjaC9hcm02NC9ib290L2R0cy9zb2Npb25leHQv dW5pcGhpZXItcHhzMy5kdHNpOiAgICAgICAgICAgICAgICAgICAgICAgcG9ydHMtaW1wbGVtZW50 ZWQgPSA8MT47Cj4gCj4gCj4gU3VyZSwgaWYgdGhlIHBvcnRzIGltcGxlbWVudGVkIHJlZ2lzdGVy IHdhcyBzdGlja3kgKGtlcHQgaXRzIHZhbHVlIGFmdGVyIGEKPiByZXNldCksIHRoZW4gSSB0aGlu ayBSb2IncyBzdWdnZXN0aW9uIHdvdWxkIG1ha2Ugc2Vuc2UuCj4gCj4gCgpUaGFuayB5b3UgdmVy eSBtdWNoIGZvciB0aGUgY2xhcmlmaWNhdGlvbi4KCj4gCj4gS2luZCByZWdhcmRzLAo+IE5pa2xh cwoKQmVzdCByZWdhcmRzLApZdWxpbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5203CA0EED for ; Fri, 29 Aug 2025 06:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TZC8hECrmozTERbvSyrRcd1R2QhN7OHBRKn+qaejoQQ=; b=tSCDl6kHm7scQ7 OjAJZWkLJJj5p+qFFgUXCs5323U6X3ihfwmliscAWymIl4wzixYVdg+uuBC4JzJAsTCDMLQZ+ODSn d9N4SNiyndEpQwzgsRhYkNfArIwCZXENQ8nHdZm1CoWwIhP6MCi4awExzjbhdf4EhgDJjDQh7D2rX nexQixtMQK8GpzDdoy7SVhs7HnlY+9YVdG6yqSNU7XvETkOQ9IgdeZqWxuHT0wiVi4ITW+VrJg1RV CA0a83eGzpLIj344mBayKuEgmcizv4686p9h1ALliKMsa8zuizqnMH6Es536l6Opd+YCvAXcQ3LRN JJWbGu7cS773bbI88Jyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ursVP-00000004dCc-1YWg; Fri, 29 Aug 2025 06:22:35 +0000 Received: from azure-sdnproxy.icoremail.net ([52.229.205.26]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ursVL-00000004d9s-3lO9 for linux-phy@lists.infradead.org; Fri, 29 Aug 2025 06:22:34 +0000 Received: from luyulin$eswincomputing.com ( [10.12.96.77] ) by ajax-webmail-app2 (Coremail) ; Fri, 29 Aug 2025 14:22:11 +0800 (GMT+08:00) X-Originating-IP: [10.12.96.77] Date: Fri, 29 Aug 2025 14:22:11 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: luyulin@eswincomputing.com To: "Niklas Cassel" Cc: "Rob Herring" , dlemoal@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, ningyu@eswincomputing.com, zhengyu@eswincomputing.com, linmin@eswincomputing.com, huangyifeng@eswincomputing.com, fenglin@eswincomputing.com, lianghujun@eswincomputing.com Subject: Re: Re: Re: [PATCH v2 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2024.2-cmXT6 build 20241203(6b039d88) Copyright (c) 2002-2025 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: References: <20250819134722.220-1-luyulin@eswincomputing.com> <20250819135413.386-1-luyulin@eswincomputing.com> <692e11ca.843.198f0337528.Coremail.luyulin@eswincomputing.com> MIME-Version: 1.0 Message-ID: <4ab70c6a.8be.198f47da494.Coremail.luyulin@eswincomputing.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: TQJkCgDHZpUTR7Foff_EAA--.23769W X-CM-SenderInfo: pox13z1lq6v25zlqu0xpsx3x1qjou0bp/1tbiAgEJA2iwhNAS7QAA s6 X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_232232_092776_4F1F5E18 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > On Thu, Aug 28, 2025 at 06:22:40PM +0800, luyulin@eswincomputing.com wrote: > > > > Do you mean that ports-implemented should be removed from the dts, > > and the corresponding register should be configured by the firmware > > (which is U-Boot on the HiFive Premier P550 board)? Is this understanding correct? > > If so, when the driver is removed, a reset will be triggered, > > causing the configuration of this register to be lost, > > which will result in an error when insmod the driver again. > > My 50 cents, > > if the ports implemented register gets reset from the reset_control_reset() > in ahci_platform_assert_rsts(), then it seems like having ports-implemented > in device tree is acceptable. > In our design, the ports implemented register gets reset from the ahci_platform_assert_rsts(). > There are a bunch of device trees that have this already: > arch/arm/boot/dts/qcom/qcom-apq8064.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/qcom/qcom-ipq8064-v2.0.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/samsung/exynos5250.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/socionext/uniphier-pro4.dtsi: ports-implemented = <1>; > arch/arm/boot/dts/socionext/uniphier-pro4.dtsi: ports-implemented = <1>; > arch/arm/boot/dts/socionext/uniphier-pxs2.dtsi: ports-implemented = <1>; > arch/arm/boot/dts/st/stih407-family.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/st/stih407-family.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/ti/omap/dra7-l4.dtsi: ports-implemented = <0x1>; > arch/arm/boot/dts/ti/omap/omap5-l4.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/mediatek/mt7622.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3568.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3576.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3576.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3588-base.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3588-base.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi: ports-implemented = <0x1>; > arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi: ports-implemented = <1>; > arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi: ports-implemented = <1>; > > > Sure, if the ports implemented register was sticky (kept its value after a > reset), then I think Rob's suggestion would make sense. > > Thank you very much for the clarification. > > Kind regards, > Niklas Best regards, Yulin -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy