From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Eric Anholt" <eric@anholt.net>,
"Maíra Canal" <mcanal@igalia.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Doug Berger" <opendmb@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.
Date: Wed, 4 Dec 2024 11:08:46 -0800 [thread overview]
Message-ID: <4ab9673a-03a7-4358-b95d-eef514607bc2@broadcom.com> (raw)
In-Reply-To: <44c233d7-87d7-4dbb-a0d0-9e93ea497622@kernel.org>
On 12/2/24 07:24, Krzysztof Kozlowski wrote:
> On 02/12/2024 15:32, Dave Stevenson wrote:
>> Resolves the issues on clocks and power nodes
>
> Which issues? Be specific. Such commit is unprecise and not really
> helpful. We see it from the diff that this is "some issue". What we do
> not see is WHY and WHAT the ISSUE is.
A link to the robot email would have probably been helpful in
understanding which dt checker errors are being fixed here. Regardless,
as indicated in patch #4, those commit messages will be discarded since
I intend to fixup the original commits directly into my tree I would not
put too much effort into addressing any comments there, unless there is
some piece of information that should have been provided in the original
commit, in which case I can squash, rather than fixup.
--
Florian
prev parent reply other threads:[~2024-12-04 19:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 14:31 [PATCH 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset Dave Stevenson
2024-12-02 14:31 ` [PATCH 1/7] dtbindings: display: bcm2711-hdmi: Correct bindings for 2712 Dave Stevenson
2024-12-02 15:16 ` Krzysztof Kozlowski
2024-12-02 15:46 ` Rob Herring (Arm)
2024-12-02 14:31 ` [PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for BCM2712 Dave Stevenson
2024-12-02 15:18 ` Krzysztof Kozlowski
2024-12-02 14:31 ` [PATCH 3/7] dt-bindings: gpio: brcmstb: add gpio-line-name Dave Stevenson
2024-12-02 15:18 ` Krzysztof Kozlowski
2024-12-02 15:45 ` Stefan Wahren
2024-12-02 14:31 ` [PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline Dave Stevenson
2024-12-02 15:20 ` Krzysztof Kozlowski
2024-12-02 15:24 ` Maxime Ripard
2024-12-04 19:05 ` Florian Fainelli
2024-12-02 14:31 ` [PATCH 5/7] arm64: dts: broadcom: Add interrupt-controller flag for intc on BCM2712 Dave Stevenson
2024-12-02 15:22 ` Krzysztof Kozlowski
2024-12-02 14:31 ` [PATCH 6/7] arm: dts: broadcom: Add interrupt-controller flag for intc on BCM2711 Dave Stevenson
2024-12-02 15:40 ` Stefan Wahren
2024-12-02 14:32 ` [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712 Dave Stevenson
2024-12-02 15:24 ` Krzysztof Kozlowski
2024-12-04 19:08 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ab9673a-03a7-4358-b95d-eef514607bc2@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=airlied@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-list@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=opendmb@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.