All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tauro, Riana" <riana.tauro@intel.com>
To: Sk Anirban <sk.anirban@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <badal.nilawar@intel.com>,
	<karthik.poosa@intel.com>, <raag.jadav@intel.com>,
	<soham.purkait@intel.com>,  <mallesh.koujalagi@intel.com>
Subject: Re: [PATCH] drm/xe/survivability: Fix infinite loop in aux info traversal
Date: Thu, 19 Nov 2026 10:42:19 +0530	[thread overview]
Message-ID: <4abcbc50-5014-4e1a-a22c-4ab9fac32a57@intel.com> (raw)
In-Reply-To: <20261118185015.3164387-2-sk.anirban@intel.com>


On 19-11-2026 00:20, Sk Anirban wrote:
> Stop traversing the aux info linked list when an entry references
> itself, preventing an endless loop and soft lockup during probe.
>
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_survivability_mode.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 91a0680e449b..34d39e68ff36 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -172,8 +172,14 @@ static void populate_survivability_info(struct xe_device *xe)
>   	if (reg_value & AUXINFO_SUPPORT) {
>   		for (id = REG_FIELD_GET(AUXINFO_REG_OFFSET, reg_value);
>   		     id >= AUX_INFO0 && id < MAX_SCRATCH_REG;
> -		     id =  REG_FIELD_GET(AUXINFO_HISTORY_OFFSET, info[id]))
> +		     id =  REG_FIELD_GET(AUXINFO_HISTORY_OFFSET, info[id])) {
>   			set_survivability_info(mmio, info, id);
> +			if (REG_FIELD_GET(AUXINFO_HISTORY_OFFSET, info[id]) == id) {

Thanks for fixing this. you can add the fixes tag
How about bitmask ? If there is a bug in fw where 3->5 ->3. We would be 
stuck in loop again.


> +				xe_warn(xe, "survivability: %s points to itself, stopping aux info walk\n",
> +					reg_map[id]);
> +				break;
> +			}
> +		}
>   	}
>   }
>   

  parent reply	other threads:[~2026-11-19  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:50 [PATCH] drm/xe/survivability: Fix infinite loop in aux info traversal Sk Anirban
2026-11-18 19:16 ` sashiko-bot
2026-11-19  0:43 ` ✓ CI.KUnit: success for " Patchwork
2026-11-19  1:22 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-19  5:12 ` Tauro, Riana [this message]
2026-11-19  5:13   ` [PATCH] " Tauro, Riana
2026-11-19  5:19   ` Anirban, Sk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4abcbc50-5014-4e1a-a22c-4ab9fac32a57@intel.com \
    --to=riana.tauro@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.