All of lore.kernel.org
 help / color / mirror / Atom feed
From: "heying (H)" <heying24@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <nsaenzjulienne@suse.de>, <sudeep.holla@arm.com>,
	<linus.walleij@linaro.org>, <robh@kernel.org>,
	<john.stultz@linaro.org>, <colin.king@canonical.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration
Date: Tue, 6 Apr 2021 11:24:23 +0800	[thread overview]
Message-ID: <4abf2891-87f3-ffe5-db36-059d31ac3761@huawei.com> (raw)
In-Reply-To: <YGcpdDrDJiXQX2ZJ@kroah.com>

Hello,

在 2021/4/2 22:25, Greg KH 写道:
> On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote:
>> When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC
>> is not set, compiling errors are encountered as follows:
>>
>> drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk':
>> qcom_scm-smc.c:(.text+0x36): undefined reference to `__arm_smccc_smc'
>> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call':
>> qcom_scm-legacy.c:(.text+0xe2): undefined reference to `__arm_smccc_smc'
>> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call_atomic':
>> qcom_scm-legacy.c:(.text+0x1f0): undefined reference to `__arm_smccc_smc'
>>
>> So add dependency on HAVE_ARM_SMCCC in QCOM_SCM configuration.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: He Ying <heying24@huawei.com>
>> ---
>>   drivers/firmware/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
> What commit caused this problem to show up?  Please add a "Fixes:" tag
> in here and resend.

OK. I'll resend.


Thanks.


      reply	other threads:[~2021-04-06  3:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  6:49 [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration He Ying
2021-04-02 14:25 ` Greg KH
2021-04-06  3:24   ` heying (H) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4abf2891-87f3-ffe5-db36-059d31ac3761@huawei.com \
    --to=heying24@huawei.com \
    --cc=colin.king@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.