All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ayushi Makhija <quic_amakhija@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robdclark@gmail.com,
	dmitry.baryshkov@linaro.org, sean@poorly.run,
	marijn.suijten@somainline.org, andersson@kernel.org,
	robh@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
	konradybcio@kernel.org, conor+dt@kernel.org,
	andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
	jonas@kwiboo.se, jernej.skrabec@gmail.com,
	quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com,
	quic_vproddut@quicinc.com, quic_jesszhan@quicinc.com
Subject: Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes
Date: Fri, 28 Mar 2025 15:28:20 +0100	[thread overview]
Message-ID: <4aebd1f6-5098-4548-adae-843db8f45aa5@kernel.org> (raw)
In-Reply-To: <d64bf3b3-7c4d-490e-8bd7-1ad889aa7472@quicinc.com>

On 13/03/2025 13:10, Ayushi Makhija wrote:

...

> 
>> +
>> +			anx_bridge_1: anx7625@58 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> In this I have changed the node name as anx_bridge1 : anx7625@58.

Except that it is difficult to understand what is what, let's recap.

Original code was:
	anx_bridge_1: anx7625@58 {

You said you changed it to:

	anx_bridge1 : anx7625@58.

and now I give my offer: I offer to buy a beer (or tee/coffee/juice) to
anyone who will spot the difference(s) between these two node names,
IOW, tell me what changed here.

Best regards,
Krzysztof

  parent reply	other threads:[~2025-03-28 14:28 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 12:24 [PATCH v2 00/10] Add DSI display support for SA8775P target Ayushi Makhija
2025-03-11 12:24 ` [PATCH v2 01/10] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY Ayushi Makhija
2025-03-12 11:44   ` Krzysztof Kozlowski
2025-03-11 12:24 ` [PATCH v2 02/10] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL Ayushi Makhija
2025-03-12 11:44   ` Krzysztof Kozlowski
2025-03-13  9:48     ` Ayushi Makhija
2025-03-11 12:24 ` [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P Ayushi Makhija
2025-03-11 15:36   ` Dmitry Baryshkov
2025-03-12 11:45   ` Krzysztof Kozlowski
2025-03-13  9:04     ` Ayushi Makhija
2025-04-08 10:38     ` Ayushi Makhija
2025-04-08 11:03       ` Krzysztof Kozlowski
2025-04-08 11:44         ` Dmitry Baryshkov
2025-04-08 18:42           ` Krzysztof Kozlowski
2025-04-08 20:26             ` Dmitry Baryshkov
2025-04-09  6:07               ` Krzysztof Kozlowski
2025-04-09 15:24                 ` Dmitry Baryshkov
2025-04-10  6:08                   ` Krzysztof Kozlowski
2025-04-10  9:16                     ` Dmitry Baryshkov
2025-04-14 10:03                       ` Ayushi Makhija
2025-03-11 12:24 ` [PATCH v2 04/10] drm/msm/dsi: add DSI PHY configuration " Ayushi Makhija
2025-03-11 15:37   ` Dmitry Baryshkov
2025-03-11 12:24 ` [PATCH v2 05/10] drm/msm/dsi: add DSI support for SA8775P Ayushi Makhija
2025-03-11 15:38   ` Dmitry Baryshkov
2025-03-11 12:24 ` [PATCH v2 06/10] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes Ayushi Makhija
2025-03-11 15:38   ` Dmitry Baryshkov
2025-03-11 12:24 ` [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes Ayushi Makhija
2025-03-12 11:48   ` Krzysztof Kozlowski
2025-03-13 12:10     ` Ayushi Makhija
2025-03-28  9:43       ` Ayushi Makhija
2025-03-28 12:45         ` Dmitry Baryshkov
2025-03-28 14:22           ` Krzysztof Kozlowski
2025-03-28 19:45             ` Dmitry Baryshkov
2025-03-28 14:28       ` Krzysztof Kozlowski [this message]
2025-03-30 10:36         ` Dmitry Baryshkov
2025-04-03  9:48           ` Ayushi Makhija
2025-03-11 12:24 ` [PATCH v2 08/10] drm/bridge: anx7625: enable HPD interrupts Ayushi Makhija
2025-03-11 15:39   ` Dmitry Baryshkov
2025-03-20 21:06     ` Ayushi Makhija
2025-03-21 17:37       ` Dmitry Baryshkov
2025-03-11 12:24 ` [PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic Ayushi Makhija
2025-03-11 15:41   ` Dmitry Baryshkov
2025-03-12  9:47     ` Ayushi Makhija
2025-03-12 11:03       ` Dmitry Baryshkov
2025-03-13  6:44         ` Ayushi Makhija
2025-03-14 10:56           ` Dmitry Baryshkov
2025-03-11 12:24 ` [PATCH v2 10/10] drm/bridge: anx7625: change the gpiod_set_value API Ayushi Makhija

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aebd1f6-5098-4548-adae-843db8f45aa5@kernel.org \
    --to=krzk@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andersson@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_amakhija@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=quic_rajeevny@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.