From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A10DC3DA4A for ; Wed, 14 Aug 2024 07:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:in-reply-to:message-id:references: mime-version:subject:reply-to:sender:list-id:list-help: list-subscribe:list-unsubscribe:list-post:list-owner: list-archive; bh=sPQx2TjSLJV/013VKDzLxDEqfE1u1uTtulAk48nZuRI=; b=gQ3TEg32jiXhisYZTzhkn5TKagYT97qolOMNH+O4V4GQh7WfddZktOxA D/kr7AxpdXdTFAd+IYIpZUo8X6v3NXgGkO/9SSw1t7a6Yr8RoKPs+raYo 6VKpqeysB91H/U9dJT0KAbWfS7u/UhOD8QGTsLppRpC6oXFuLgcjEbgx6 M=; Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of cocci-owner@inria.fr designates 128.93.162.160 as permitted sender) identity=mailfrom; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="cocci-owner@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@sympa.inria.fr) identity=helo; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="postmaster@sympa.inria.fr"; x-conformance=spf_only Authentication-Results: mail2-relais-roc.national.inria.fr; spf=Pass smtp.mailfrom=cocci-owner@inria.fr; spf=None smtp.helo=postmaster@sympa.inria.fr; dkim=pass (signature verified) header.i=@inria.fr X-IronPort-AV: E=Sophos;i="6.09,288,1716242400"; d="scan'208";a="178955987" Received: from prod-listesu18.inria.fr (HELO sympa.inria.fr) ([128.93.162.160]) by mail2-relais-roc.national.inria.fr with ESMTP; 14 Aug 2024 09:19:45 +0200 Received: by sympa.inria.fr (Postfix, from userid 20132) id 68AA7E0141; Wed, 14 Aug 2024 09:19:45 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 96358E0035 for ; Wed, 14 Aug 2024 09:19:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=sPQx2TjSLJV/013VKDzLxDEqfE1u1uTtulAk48nZuRI=; b=pw1HzK5ThKTkaW2QCs5CsFlq21I5oc/7dkVr5JnStgyTd1y+plGSjZSz JR80t0vwpHnSFFqL9vRLXWpGB78BBibBGmY20wggKFULFokvr87sLFJ5f rLI0roJCWcjcWINUyzeZfCVRTLaElMlO7pnDoRmQTDGu9zmAf7EnNod7g w=; X-IronPort-AV: E=Sophos;i="6.09,288,1716242400"; d="scan'208";a="94066738" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2024 09:19:44 +0200 Date: Wed, 14 Aug 2024 09:19:43 +0200 (CEST) From: Julia Lawall To: Andrzej Hajda cc: Julia Lawall , Peter Senna Tschudin , Peter Senna Tschudin , cocci@inria.fr In-Reply-To: <03d047e0-577c-4c39-b75e-6f8fb998ae57@intel.com> Message-ID: <4aed4763-9b3c-c21f-693a-e7d4281f8384@inria.fr> References: <25273c09-ded5-4f43-82ee-956f66a8cd0e@linux.intel.com> <1e637cb0-24cd-dc10-9178-69f314598ce@inria.fr> <03d047e0-577c-4c39-b75e-6f8fb998ae57@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-842455172-1723619983=:3440" Subject: Re: [cocci] Iterator macros Reply-To: Julia Lawall X-Loop: cocci@inria.fr X-Sequence: 1854 Errors-To: cocci-owner@inria.fr Precedence: list Precedence: bulk Sender: cocci-request@inria.fr X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-842455172-1723619983=:3440 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT > I guess the issue here could be a problem with parsing igt code (it is also an > issue with kernel drivers using iterators). > Cocci quite often does not recognize automatically iterators or other > constructs, and does not scan them at all. > Try run for example: > $ spatch --parse-c tests/intel/gem_ctx_exec.c > ... > NB total files = 1; perfect = 0; pbs = 1; timeout = 0; =========> 0% > nb good = 385,  nb passed = 19 =========> 3.12% passed > nb good = 385,  nb bad = 204 =========> 66.45% good or passed > > As I understand, lines marked as "bad" are skipped during cocci pass, am I > right? > Some workaround is to define iterators by hand in the script or include files. The following file: #define igt_main int main () #define igt_simple_main int main () #define igt_fixture #define igt_subtest_group #define igt_dynamic(x) YACFE_ITERATOR #define igt_dynamic_f(x) YACFE_ITERATOR #define igt_subtest(x) YACFE_ITERATOR #define igt_subtest_with_dynamic(x) YACFE_ITERATOR #define igt_subtest_with_dynamic_f(x) YACFE_ITERATOR #define igt_subtest_f(x) YACFE_ITERATOR #define igt_until_timeout(x) YACFE_ITERATOR #define igt_while_interruptible(x) YACFE_ITERATOR #define igt_list_for_each_entry_safe_reverse(x) YACFE_ITERATOR #define igt_list_for_each_entry_safe(x) YACFE_ITERATOR #define igt_list_for_each_entry(x) YACFE_ITERATOR #define _Atomic(x) x managed to parse over 98% of the lines in https://gitlab.freedesktop.org/drm/igt-gpu-tools Command line spatch --parse-c . --macro-file-builtins igt.h I'll check on the driver file you mentioned. Thanks. julia --8323329-842455172-1723619983=:3440--