From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD1716D4E8 for ; Wed, 12 Jun 2024 10:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718186937; cv=none; b=VoY5UJiziMI19DZ5iEKdu4plB0s4ICJb2WrqlKzG04UO3TJcSCLmmpCQdy1eThXbFvCx4thN+XbJ53mKOHJ3hkux7VKdddp2NP7cZSUBtJ98PcZINK5dk/qfDant5NbVHivSvSyfNvg+mMOwlrP4iLt7HgHbAJ8oPnHRMCZQ3KY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718186937; c=relaxed/simple; bh=pw7HgWQK4sD0qp5qxOO2K9LVDQueOS/Y695OIEk7J9I=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=bm8B2/2ndTPRVy3QPHN5Y2mkfuC8ahV6cuVey15tTy4FmCoLvZCL+NLpwuPXAwtBtsSbG60QrNuOkYdE68GoEhRtp0kpHcZKOKXAusrj0V3pETVdOyyecTQRlBd06IGX7sldQvPxw08GKOGOHhNvgN9cCRNtpdYDLE9tgC9lfPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q+WKDUgC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q+WKDUgC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718186933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LLOfKzS9Is4M6RNWbUE4sMUvQ49ghZMG/yPmnPnTpYY=; b=Q+WKDUgCEpp/RquVuRoyz0/6JOUDYAWAzL5wLxB+KfLtbz/nwT4nCC6j0jGG910JIXe8Un eowQ89H0gDLzLyatVXBeC0WhQmVGPv4X4xp3ZXlxeCHXRPBHqFneLMlqxlN1NpiSppC4Nf AG9MyVb7zyycuVPi3Bs+nQhGsDW71cc= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-Gs1pJ1k9PeizIfMsj_Zu6A-1; Wed, 12 Jun 2024 06:08:52 -0400 X-MC-Unique: Gs1pJ1k9PeizIfMsj_Zu6A-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a6f0f7d6eaaso85112366b.1 for ; Wed, 12 Jun 2024 03:08:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718186931; x=1718791731; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLOfKzS9Is4M6RNWbUE4sMUvQ49ghZMG/yPmnPnTpYY=; b=WtswNXQmBBaN1JeCGdT+XDf6UkxjTxq1+XQ5nR6zg9LQ3v7wOFy0gkWiWB/bkds1f/ 05UJ5E9NSBBoTdE9KqMPhAMKtVjbFQU1b9PJyCCsxlx5iW2jGXGHQbijLBt79/j+VMPn JduuJpG5afn61sepdJqkfLM31yTCfpMqPjQSs3lp3455iKCzWuSJbvrCViAxaPamqXPM j9ETKRylN/f4Ss64CayMfhLnQPVaKJTUDt24MLYCbK3tn7vVEIeDU7D0CSAfPy4nt75Y hFyHv9lJiYtqN2IMZj/K0GxbrGJSZ7zjWehMosVy82YfxjvC8H1lnENAptcm9M+gX43V MrvA== X-Forwarded-Encrypted: i=1; AJvYcCVQ83QJS+ONuRedsbnIwxUZbXEb5lwwgdh94kKfqNQlSEo/usHwd2+hSDziJZFPqcbxlwgrLSfNA82ONuWPd1D5M25GIBQEjUSgpQ== X-Gm-Message-State: AOJu0YzXKY8BnarjbmgnTrj+7AsfLrm05i1ETz0unqCzM8XLQvoktaO2 kUG9nZmxGyKt4B4ZEaVgutcPJMJtmgnmPywVmUANG3L80JVAV+2T3vPq05IiIrCNCVVTcoOzpLA 8z63ONI11UTRnu77eQAp5h7ou9bwpEpLrUpN8KboyvemEroijbnWNLldwGik= X-Received: by 2002:a17:906:64d:b0:a6e:4e0:8a56 with SMTP id a640c23a62f3a-a6f34dddf97mr345487266b.32.1718186931116; Wed, 12 Jun 2024 03:08:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDhKNb1woactSSXmyEjuzW+ovpxvmll3Rtvi6rex9IVe/7mfN7yKK6wLzv4CqXyzqlxcF2eg== X-Received: by 2002:a17:906:64d:b0:a6e:4e0:8a56 with SMTP id a640c23a62f3a-a6f34dddf97mr345485466b.32.1718186930674; Wed, 12 Jun 2024 03:08:50 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f0369399csm568681366b.3.2024.06.12.03.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 03:08:50 -0700 (PDT) Message-ID: <4b387b4d-f778-4891-9f07-df5fc0a093cd@redhat.com> Date: Wed, 12 Jun 2024 12:08:49 +0200 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] ACPI: scan: Ignore Dell XPS 9320 camera graph port nodes From: Hans de Goede To: Sakari Ailus , Genes Lists , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, wentong.wu@intel.com, linux-media@vger.kernel.org, linux-acpi@vger.kernel.org, "regressions@lists.linux.dev" References: <988e48090982c89ce0c906954832fdfb09a1ce34.camel@sapience.com> <20240528084413.2624435-1-sakari.ailus@linux.intel.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 6/6/24 8:12 PM, Hans de Goede wrote: > Hi, > > +To: Rafael since this was Cc-ed to linux-acpi but never send > to Rafael directly. > > Rafael this fixes a crash in 6.10-rc1 for some users and is necessary > to make the cameras work on the Dell XPS 13 plus 9320 . > > On 5/28/24 7:09 PM, Hans de Goede wrote: >> Hi Sakari, >> >> On 5/28/24 10:44 AM, Sakari Ailus wrote: >>> Ignore camera related graph port nodes on Dell XPS 9320. They data in BIOS >>> is buggy, just like it is for Dell XPS 9315. The corresponding software >>> nodes are created by the ipu-bridge. >>> >>> Signed-off-by: Sakari Ailus >>> --- >>> Hi, >>> >>> Could you test this and see whether it fixes the warning? >>> >>> The camera might work with this change, too. >> >> Thank you I just received a Dell XPS 13 plus 9320 myself to use >> for VSC testing and I can confirm that with this patch 6.10.0-rc1 >> works, including giving a picture with the libcamera software ISP + >> 3 small libcamera patches. > > I forgot to add: > > Tested-by: Hans de Goede > Reviewed-by: Hans de Goede I just hit the same problem on another Dell laptop. It seems that all Dell laptops with IPU6 camera from the Tiger Lake, Alder Lake and Raptor Lake generations suffer from this problem. So instead of playing whack a mole with DMI matches we should simply disable ACPI MIPI DISCO support on all Dell laptops with those CPUs. I'm preparing a fix for this to replace the DMI matching now. Rafael, please drop this patch, my more generic fix will replace it and backporting will be easier without having the intermediate fix in the middle. Regards, Hans >>> drivers/acpi/mipi-disco-img.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c >>> index d05413a0672a..bf9a5cee32ac 100644 >>> --- a/drivers/acpi/mipi-disco-img.c >>> +++ b/drivers/acpi/mipi-disco-img.c >>> @@ -732,6 +732,12 @@ static const struct dmi_system_id dmi_ignore_port_nodes[] = { >>> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 9315"), >>> }, >>> }, >>> + { >>> + .matches = { >>> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 9320"), >>> + }, >>> + }, >>> { } >>> }; >>> >