From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA382187346 for ; Tue, 24 Feb 2026 06:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=85.215.255.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771914799; cv=pass; b=Ux4+FbfyN2qzzidnwv9Lk/weKGNJIlD+A3Qf4jzVM1Uf2+ypEEoSfjw+BcyCBh4Sf55FyE/odEuNrbU/yekWgXAwHCJyJfYMGWjaKCO5/9o/tudTC6Z+R5LUhsW3miRRexTHwIHsNkKBKeCWlkU75eXantXUKhVBZDaRTV0GzYI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771914799; c=relaxed/simple; bh=V1wSE2rze+Hp0IZkuhJ7gfA8XUED63NMJHfi6NbuGzE=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=cYJzSrmimIxlta2eFUJcS2HzvibK7QDIFk1bD+YzNrCfvfQtqh2gdYMHziSaPKyk0Wc671UtJNhtPzau8lByHqdwf2JAnuIz0po0qBDQRJMUjBjZV6pbvNPUezx/DmsyzHA8Zp8+GvVy1f7KG2CYfz3r1sQSTL2+j4TKU5djjWY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de; spf=none smtp.mailfrom=xenosoft.de; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b=dIU0Hi+G; dkim=permerror (0-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b=2Jnhv1q0; arc=pass smtp.client-ip=85.215.255.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="dIU0Hi+G"; dkim=permerror (0-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="2Jnhv1q0" ARC-Seal: i=1; a=rsa-sha256; t=1771914615; cv=none; d=strato.com; s=strato-dkim-0002; b=Q26Cm+jcbNkxDf2rDq4TsjmdoVtP5QfyjtEzLpCCzuGhuzxTvygitsgyOII4fp9duB WdiezGDaQU70SmFvauPoyIbHUZP8WU9fUFVVOJtQvqYQWykzjREbbuqeQlLUR+8jAh2t mt0wCbZOlAqKgKjMBmZZKo5f0CZu0Pu1qkOpxezfYzuvoFUjfpbDrCESwc+VmfrBrgO2 Km3NUDdD4UwjX0bX7OQ77u4os4kMD9IFqPJ+S+fLf6Blcx4EL3uR+nXDRaoU7Jp494kg 4TA0eQ7SpeA/kIJFXB1r+5xQUrLRdP92fwejx0aCQ06s6IU+WpKKW5R9BQloTmWvp3N0 cD1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1771914615; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject:Cc:Date: From:Subject:Sender; bh=aJnFllV8sc5HH69M+vVx3xOhhAroz7QXWl4LvdQTNRk=; b=iI3RxrBq20wlTIUJ8u/WeXAh8RV5H9ca9hmKoCIZIEgpHrrtB3hHlCoY9zrrBmBmPX GJopvncQypapfAZPGj8qh1Kn41xjMWCKcmI+QQ/Bla2hT/beUmOjtEn0QMjWKi1ZIU0o tnMuYPnOlHHPk60xR+kFLjWZz5zgdiuDPsVDqHMNUPdGjgFTN7V8lYgfkrnmMck7vAmo 3y9o/OPyrPs8Vvla+nTu6WOQG1ei/QSusFFYFs8qlBNzGywasBjmXqdpQL8/GhgJvvpq Gi3Z6luWZbly3A/ib4ixBT8nv8N7nMoxSMkHvrszR7OMxszNdJ3SD36IVH4TT8XSuc9+ oP1g== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1771914615; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject:Cc:Date: From:Subject:Sender; bh=aJnFllV8sc5HH69M+vVx3xOhhAroz7QXWl4LvdQTNRk=; b=dIU0Hi+GdOJ+zxLDn63tecHJyi0+2BNn/ytQND/d1ZvsqC2tq+4Ds74SVO2x6ul7mx QxG66/DZ74P4TClBwdntPoRM1F7wF5UqHlN0JVF0Gmdc7Z1arPNT6gEynE/JbQlWXlGU tiE2XuB55iReUHGORNqUbnZgAvEpjOIy0YSSgbqLRMLSNkRQS4a4EoKGWfcwt1uL/nLg I26DiUC3T4vwgpUg1QKmbtPuKe1PWxrz2tf73l1HPdTYLqMdSuIkvGqP2027Hq4NCOOY VErDEzhoiNB2C6SOHJNJWxfWRV1/GbUY18Abi017aSbPtrbKIjvcpjYFHoxrQxfCQxth k0HA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1771914615; s=strato-dkim-0003; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject:Cc:Date: From:Subject:Sender; bh=aJnFllV8sc5HH69M+vVx3xOhhAroz7QXWl4LvdQTNRk=; b=2Jnhv1q0GOHKoQqFiVqqvkimy10xbkEsJUdmAJMyB4ApemmC7J2Dh0Ff9fHYDi4mvh C992mMwrWck5TUqZzaDw== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGN0rBVhd9dFr4thIFiqT9BURIi+l6B7g" Received: from void-ppc.a-eon.tld by smtp.strato.de (RZmta 55.0.1 DYNA|AUTH) with ESMTPSA id e9337f21O6UEjRA (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 24 Feb 2026 07:30:14 +0100 (CET) Subject: Re: [Linux PPC] 7.0-rc1: e500_mmu.c:923:26: error: assignment to 'struct tlbe_priv *' from incompatible pointer type 'struct tlbe_ref *' To: Kees Cook , "Christophe Leroy (CS GROUP)" Cc: Shrikanth Hegde , linuxppc-dev , "kvm-ppc@vger.kernel.org" , Madhavan Srinivasan , "R.T.Dickinson" , hypexed@yahoo.com.au, mad skateman , Christian Zigotzky References: <709b864f-9daa-4a48-b3d6-39baedce63b2@linux.ibm.com> <843b7c60-23f1-47d0-b4e8-2147c3e40c23@linux.ibm.com> <2a27e6fc-7eb4-41a5-ba88-58f6a22625b5@xenosoft.de> <1d79ec6f-ce7f-4432-80e0-a54fa1668642@linux.ibm.com> <2cbd1e19-ac99-29c3-ab89-3c58a9863e5a@xenosoft.de> <2d2d4735-04e0-46a0-93c6-654507fe2ae1@kernel.org> <2536c3e7-18d2-47cb-88c6-36f94c61c1c6@kernel.org> <202602231439.FFDA50B@keescook> From: Christian Zigotzky Organization: A-EON Open Source Message-ID: <4b441394-6dd3-cc58-e9e4-6ff840fdcda5@xenosoft.de> Date: Tue, 24 Feb 2026 07:30:14 +0100 X-Mailer: BrassMonkey/33.9.1 Precedence: bulk X-Mailing-List: kvm-ppc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <202602231439.FFDA50B@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23/02/26 23:40, Kees Cook wrote: > On Mon, Feb 23, 2026 at 08:38:29PM +0100, Christophe Leroy (CS GROUP) wrote: >> >> Le 23/02/2026 à 19:07, Christophe Leroy (CS GROUP) a écrit : >>> +Kees >>> >>> Hello, >>> >>> Le 23/02/2026 à 17:48, Christian Zigotzky a écrit : >>>> Hello, >>>> >>>> Compiling issue for e5500 machines for the RC1 of kernel 7.0: >>>> >>>> arch/powerpc/kvm/e500_mmu.c: In function 'kvmppc_e500_tlb_init': >>>> arch/powerpc/kvm/e500_mmu.c:923:26: error: assignment to 'struct >>>> tlbe_priv *' from incompatible pointer type 'struct tlbe_ref *' [- >>>> Werror=incompatible-pointer-types] >>>>    923 |  vcpu_e500->gtlb_priv[0] = kzalloc_objs(struct tlbe_ref, >>>>        |                          ^ >>>> arch/powerpc/kvm/e500_mmu.c:928:26: error: assignment to 'struct >>>> tlbe_priv *' from incompatible pointer type 'struct tlbe_ref *' [- >>>> Werror=incompatible-pointer-types] >>>>    928 |  vcpu_e500->gtlb_priv[1] = kzalloc_objs(struct tlbe_ref, >>>> >>>> Temporary solution: # CONFIG_VIRTUALIZATION is not set >>>> >>>> Please solve this issue. >>>> >>> Must be one of: >>> >>> 189f164e573e Convert remaining multi-line kmalloc_obj/flex GFP_KERNEL uses >>> bf4afc53b77a Convert 'alloc_obj' family to use the new default >>> GFP_KERNEL argument >>> 69050f8d6d07 treewide: Replace kmalloc with kmalloc_obj for non-scalar >>> types >>> >> Can you try following change: >> >> diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c >> index 48580c85f23b..75ed1496ead5 100644 >> --- a/arch/powerpc/kvm/e500_mmu.c >> +++ b/arch/powerpc/kvm/e500_mmu.c >> @@ -920,12 +920,12 @@ int kvmppc_e500_tlb_init(struct kvmppc_vcpu_e500 >> *vcpu_e500) >> vcpu_e500->gtlb_offset[0] = 0; >> vcpu_e500->gtlb_offset[1] = KVM_E500_TLB0_SIZE; >> >> - vcpu_e500->gtlb_priv[0] = kzalloc_objs(struct tlbe_ref, >> + vcpu_e500->gtlb_priv[0] = kzalloc_objs(struct tlbe_priv, >> vcpu_e500->gtlb_params[0].entries); >> if (!vcpu_e500->gtlb_priv[0]) >> goto free_vcpu; >> >> - vcpu_e500->gtlb_priv[1] = kzalloc_objs(struct tlbe_ref, >> + vcpu_e500->gtlb_priv[1] = kzalloc_objs(struct tlbe_priv, >> vcpu_e500->gtlb_params[1].entries); >> if (!vcpu_e500->gtlb_priv[1]) >> goto free_vcpu; > That looks like the correct fix to me. The old type was the correct size, > but was just the wrong type. Sorry I missed it when doing my tree-wide > multi-arch builds! What build target (or Kconfig) was needed to reach > this code? > > Fixes: 69050f8d6d07 ("treewide: Replace kmalloc with kmalloc_obj for non-scalar types") > Reviewed-by: Kees Cook > > Thanks! > It works. Thank you. Tested-by: Christian Zigotzky -- Sent with BrassMonkey 33.9.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_33.9.1)