From: Jens Axboe <axboe@kernel.dk>
To: Adam Manzanares <adam.manzanares@hgst.com>, tj@kernel.org
Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v3 1/2] block: Add iocontext priority to request
Date: Wed, 12 Oct 2016 08:49:54 -0600 [thread overview]
Message-ID: <4b60fe5d-113f-9361-bbae-7473002500ba@kernel.dk> (raw)
In-Reply-To: <1476218427-4021-2-git-send-email-adam.manzanares@hgst.com>
On 10/11/2016 02:40 PM, Adam Manzanares wrote:
> Patch adds an association between iocontext ioprio and the ioprio of
> a request. This feature is only enabled if a queue flag is set to
> indicate that requests should have ioprio associated with them. The
> queue flag is exposed as the req_prio queue sysfs entry.
Honestly, I don't get this patchset. For the normal file system path, we
inherit the iocontext priority into the bio. That in turns gets
inherited by the request. Why is this any different?
It'd be much cleaner to just have 'rq' inherit the IO priority from the
io context when the 'rq' is allocated, and ensuring that we inherit and
override this if the bio has one set instead. It should already work
like that.
And in no way should we add some sysfs file to control this, that is
nuts.
--
Jens Axboe
next prev parent reply other threads:[~2016-10-12 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 20:40 [PATCH v3 0/2] Enabling ATA Command Priorities Adam Manzanares
2016-10-11 20:40 ` Adam Manzanares
2016-10-11 20:40 ` [PATCH v3 1/2] block: Add iocontext priority to request Adam Manzanares
2016-10-11 20:40 ` Adam Manzanares
2016-10-12 14:49 ` Jens Axboe [this message]
2016-10-12 17:58 ` Adam Manzanares
2016-10-12 17:58 ` Adam Manzanares
2016-10-12 21:05 ` Jens Axboe
2016-10-11 20:40 ` [PATCH v3 2/2] ata: Enabling ATA Command Priorities Adam Manzanares
2016-10-11 20:40 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b60fe5d-113f-9361-bbae-7473002500ba@kernel.dk \
--to=axboe@kernel.dk \
--cc=adam.manzanares@hgst.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.