From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Agx-0007ia-6b for qemu-devel@nongnu.org; Tue, 09 May 2017 15:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Agt-00029u-SP for qemu-devel@nongnu.org; Tue, 09 May 2017 15:21:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37864) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8Agt-00029h-Gy for qemu-devel@nongnu.org; Tue, 09 May 2017 15:20:59 -0400 References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> From: Eric Blake Message-ID: <4b6be500-760b-dcd8-6113-6953bc8f0dce@redhat.com> Date: Tue, 9 May 2017 14:20:57 -0500 MIME-Version: 1.0 In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi" Subject: Re: [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, groug@kaod.org, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi From: Eric Blake To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, groug@kaod.org, pbonzini@redhat.com Message-ID: <4b6be500-760b-dcd8-6113-6953bc8f0dce@redhat.com> Subject: Re: [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/09/2017 02:04 PM, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. >=20 > CID: 1374831 >=20 > Signed-off-by: Stefano Stabellini > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZEhaZAAoJEKeha0olJ0NqdysIAIWTqT9MpDe5WpYZDOWo7lAS KLOrUVm3wz9mif1zXuR1mRPyu4x3ZbIFmvRs8PaK3Mbp9F5IGQzji8tQNrDpYU3H +aFVXz65epvRY0DPYwQseq3wBYNqUZv/mDq8ouMkKOLEmf/Vlhrf+lhHg5dxtyiz orfTVZUjMZxQK7uFkETrEjzZCEVoYb3jskdD+HhpuHmbGCoK8DKfaZLvYjgwcoT2 gsfMqUXnseKCHJ4cZlR9v76kUsoNdcsfQzE7XXmc4R36n2Y8eA6ECtWx11lxLwYV wrVk6/+q+PNmNv4qAS72Uo5DhsfWpb+Ndl6IPsMxHJO9UUc8m0SfhSXIgpQSBFQ= =EdXe -----END PGP SIGNATURE----- --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec Date: Tue, 9 May 2017 14:20:57 -0500 Message-ID: <4b6be500-760b-dcd8-6113-6953bc8f0dce@redhat.com> References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7848109058359751222==" Return-path: In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, groug@kaod.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7848109058359751222== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi Content-Type: multipart/mixed; boundary="p3m33EgmRVB7h0i2UtcNqeuTCLGPMuisl"; protected-headers="v1" From: Eric Blake To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, groug@kaod.org, pbonzini@redhat.com Message-ID: <4b6be500-760b-dcd8-6113-6953bc8f0dce@redhat.com> Subject: Re: [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> <1494356693-13190-2-git-send-email-sstabellini@kernel.org> In-Reply-To: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> --p3m33EgmRVB7h0i2UtcNqeuTCLGPMuisl Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05/09/2017 02:04 PM, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. >=20 > CID: 1374831 >=20 > Signed-off-by: Stefano Stabellini > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --p3m33EgmRVB7h0i2UtcNqeuTCLGPMuisl-- --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZEhaZAAoJEKeha0olJ0NqdysIAIWTqT9MpDe5WpYZDOWo7lAS KLOrUVm3wz9mif1zXuR1mRPyu4x3ZbIFmvRs8PaK3Mbp9F5IGQzji8tQNrDpYU3H +aFVXz65epvRY0DPYwQseq3wBYNqUZv/mDq8ouMkKOLEmf/Vlhrf+lhHg5dxtyiz orfTVZUjMZxQK7uFkETrEjzZCEVoYb3jskdD+HhpuHmbGCoK8DKfaZLvYjgwcoT2 gsfMqUXnseKCHJ4cZlR9v76kUsoNdcsfQzE7XXmc4R36n2Y8eA6ECtWx11lxLwYV wrVk6/+q+PNmNv4qAS72Uo5DhsfWpb+Ndl6IPsMxHJO9UUc8m0SfhSXIgpQSBFQ= =EdXe -----END PGP SIGNATURE----- --EOobQJ3OnDr93AN8soljKmnnLhI6Jv9wi-- --===============7848109058359751222== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7848109058359751222==--