From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libnvme: needs host-swig
Date: Sun, 29 Oct 2023 21:43:21 +0100 [thread overview]
Message-ID: <4b77e07f-b11d-4cba-9c5d-2b98ddb07777@benettiengineering.com> (raw)
In-Reply-To: <20231029113325.GX687180@scaer>
On 29/10/23 12:33, Yann E. MORIN wrote:
> Giulio, All,
>
> On 2023-10-26 17:57 +0200, Giulio Benetti spake thusly:
>> Fixes:
>> http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/libnvme/libnvme.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
>> index 38394b9931..3b622839fa 100644
>> --- a/package/libnvme/libnvme.mk
>> +++ b/package/libnvme/libnvme.mk
>> @@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
>> LIBNVME_LICENSE_FILES = COPYING
>> LIBNVME_INSTALL_STAGING = YES
>>
>> +LIBNVME_DEPENDENCIES += host-swig
>
> swig is only needed to build the python bindings, no?
> In which case it should be in the python conditional block, right?
Oh, yes, absolutely.
Thanks for reviewing.
Going to send V2
Kind regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
> Regards,
> Yann E. MORIN.
>
>> LIBNVME_CONF_OPTS += \
>> -Dtests=false
>>
>> --
>> 2.34.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-10-29 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:57 [Buildroot] [PATCH] package/libnvme: needs host-swig Giulio Benetti
2023-10-29 11:33 ` Yann E. MORIN
2023-10-29 20:43 ` Giulio Benetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b77e07f-b11d-4cba-9c5d-2b98ddb07777@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.