From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E86EAC2D0DB for ; Tue, 28 Jan 2020 15:26:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 741ED2467E for ; Tue, 28 Jan 2020 15:26:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ZH0cUEu8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mSMaf3GF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 741ED2467E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9CB331658; Tue, 28 Jan 2020 16:25:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9CB331658 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580225181; bh=WxLCI+3kBD2MduBAwFmgXxBPuNpqeHO9mGt1WrTSYpI=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZH0cUEu8AB2rmCnclngb1lX8Kd9hWpnuwE+aArTjnriJW5vq6g1hEwg2U0hFTbrFH Q+ZcGQ2UsH/9//yM/MAi9HyPDJFKQa6fLk96ANkaztM+M4bBcFK9hpSw3rOXTmP9mD keqVBPqS8o2bZt0B+Mng8HaZ1CIo+l0+9SlJrvUw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 25D67F800FF; Tue, 28 Jan 2020 16:25:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EED36F80150; Tue, 28 Jan 2020 16:25:28 +0100 (CET) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 55821F800FF for ; Tue, 28 Jan 2020 16:25:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 55821F800FF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mSMaf3GF" Received: by mail-lj1-x241.google.com with SMTP id h23so15144662ljc.8 for ; Tue, 28 Jan 2020 07:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wt1vosh5doE0CTfo450Q1EteoZWXd05+2wERnPg/Das=; b=mSMaf3GF40AF6W5ANFgPQ9CrM3aHDVjVi3gk0ESEK1kKonC5JyQSUpE93Le6B7CcgI nnGO2q8RMAXvgBgB944YXdXE1U7zrkXDU6NgsY2RBkA0cg25F4wph53rEwhwm75PnTnF Fs8jd+ay6dEc0LB3zIZKFDJz0GxzQ0N4kEZAebK1E3BZDVkLlAQ6koig5FUNzLFYuNxD ctwTshydCtIK3w6eliJf0la16m0rBr1I47VyTUpZXqluGwuy2juCMA9uGew0R83Y6zTp RQOInS/UI2BSkZpiXI8YdMaMnRYaMyVnvFBQX4xkSeh9pnF7iHgMnuNwntkiETi5sdra psFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wt1vosh5doE0CTfo450Q1EteoZWXd05+2wERnPg/Das=; b=lZ5NqrT9cWcRhyA+A/z8ZIlmRz25IOE/LhJ7hTFdzkxEbxpLwgUE+JlkeTmiyd+9eO 8tw1Z8OlztXNBgxDA7Vw8RsABndN9KNgDvej8Bn8ZV6vz8MkHRExHf7i2QTgJHEJT50Y eDICqp8xzzjEm8eOgFhIlNQNsUfaYwwjwyGytO+NMU+GB5/jw24YhbD99M2V3L4iresY 1KhPWOeacQg1BM4o9nmsQUqdySpBqkm6tPHzlClMo78dOqK2hWcgaRBjUA7EA/HsX0HH aKpSOPec+uraDAIGikjQd2R4/r5lz2ObihGFClvDmk2UPkXed9siAgyd7gS5LaNZA4Je Ue7w== X-Gm-Message-State: APjAAAWEy+xrn0W4k1mktYSiP0rPUB47JSUCsYmacY+TT5Zphk/dOYVi Pf+gUsY1fVYZiReElgeMhUY= X-Google-Smtp-Source: APXvYqxJXNRv3sXMNruaDyN8qSDfgWtYeDy/sN0vsUVncH+3pcE3rkyyiIESKlIpEkKoiYbd/aKIFg== X-Received: by 2002:a2e:7207:: with SMTP id n7mr12227173ljc.242.1580225123107; Tue, 28 Jan 2020 07:25:23 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id v7sm8187419ljd.12.2020.01.28.07.25.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 07:25:22 -0800 (PST) To: Jon Hunter , Ben Dooks References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <1aa6a4bf-10ea-001d-2d35-44494d9554f8@gmail.com> <62cea895-c1f1-a833-b63c-050642bb8a79@codethink.co.uk> From: Dmitry Osipenko Message-ID: <4b7ccb4f-ee19-a2f2-88cb-3f0dc97f9da9@gmail.com> Date: Tue, 28 Jan 2020 18:25:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjguMDEuMjAyMCAxNjoxOSwgSm9uIEh1bnRlciDQv9C40YjQtdGCOgo+IAo+IE9uIDI4LzAxLzIw MjAgMDg6NTksIEJlbiBEb29rcyB3cm90ZToKPj4gT24gMjcvMDEvMjAyMCAxOToyMywgRG1pdHJ5 IE9zaXBlbmtvIHdyb3RlOgo+Pj4gMjcuMDEuMjAyMCAyMjoyMCwgRG1pdHJ5IE9zaXBlbmtvINC/ 0LjRiNC10YI6Cj4+Pj4gMjQuMDEuMjAyMCAxOTo1MCwgSm9uIEh1bnRlciDQv9C40YjQtdGCOgo+ Pj4+Pgo+Pj4+PiBPbiAyMy8wMS8yMDIwIDE5OjM4LCBCZW4gRG9va3Mgd3JvdGU6Cj4+Pj4+PiBP biAwNy8wMS8yMDIwIDAxOjM5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+Pj4+Pj4gMDYuMDEu MjAyMCAyMjowMCwgQmVuIERvb2tzINC/0LjRiNC10YI6Cj4+Pj4+Pj4+IE9uIDA1LzAxLzIwMjAg MTA6NTMsIEJlbiBEb29rcyB3cm90ZToKPj4+Pj4+Pj4+Cj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gT24g MjAyMC0wMS0wNSAwMTo0OCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4+Pj4+Pj4+IDA1LjAx LjIwMjAgMDM6MDQsIEJlbiBEb29rcyDQv9C40YjQtdGCOgo+Pj4+Pj4+Pj4+PiBbc25pcF0KPj4+ Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gSSd2ZSBqdXN0IGdvbmUgdGhyb3VnaCB0ZXN0aW5nLgo+Pj4+ Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiBTb21lIHNpbXBsZSBkYXRhIHRlc3RzIHNob3cgMTYgYW5kIDMy LWJpdHMgd29yay4KPj4+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gVGhlIDI0IGJpdCBjYXNlIHNlZW1z IHRvIGJlIHdlaXJkLCBpdCBsb29rcyBsaWtlIHRoZSAyNC1iaXQKPj4+Pj4+Pj4+Pj4gZXhwZWN0 cwo+Pj4+Pj4+Pj4+PiAyNCBiaXQgc2FtcGxlcyBpbiAzMiBiaXQgd29yZHMuIEkgY2FuJ3Qgc2Vl IGFueSBwYWNraW5nCj4+Pj4+Pj4+Pj4+IG9wdGlvbnMgdG8KPj4+Pj4+Pj4+Pj4gZG8gMjQgYml0 IGluIDI0IGJpdCwgc28gd2UgbWF5IGhhdmUgdG8gcmVtb3ZlIDI0IGJpdCBzYW1wbGUKPj4+Pj4+ Pj4+Pj4gc3VwcG9ydAo+Pj4+Pj4+Pj4+PiAod2hpY2ggaXMgYSBzaGFtZSkKPj4+Pj4+Pj4+Pj4K Pj4+Pj4+Pj4+Pj4gTXkgcHJlZmVyZW5jZSBpcyB0byByZW1vdmUgdGhlIDI0LWJpdCBzdXBwb3J0 IGFuZCBrZWVwIHRoZSAzMgo+Pj4+Pj4+Pj4+PiBiaXQgaW4uCj4+Pj4+Pj4+Pj4+Cj4+Pj4+Pj4+ Pj4KPj4+Pj4+Pj4+PiBJbnRlcmVzdGluZy4uIEpvbiwgY291bGQgeW91IHBsZWFzZSBjb25maXJt IHRoYXQgMjRiaXQgZm9ybWF0Cj4+Pj4+Pj4+Pj4gaXNuJ3QKPj4+Pj4+Pj4+PiB1c2FibGUgb24g VDMwPwo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IElmIHRoZXJlIGlzIGFuIG9wdGlvbiBvZiAyNCBwYWNr ZWQgaW50byAzMiwgdGhlbiBJIHRoaW5rIHRoYXQgd291bGQKPj4+Pj4+Pj4+IHdvcmsuCj4+Pj4+ Pj4+Pgo+Pj4+Pj4+Pj4gSSBjYW4gdHJ5IHRlc3RpbmcgdGhhdCB3aXRoIHJhdyBkYXRhIG9uIE1v bmRheS4KPj4+Pj4+Pj4KPj4+Pj4+Pj4gSSBuZWVkIHRvIGNoZWNrIHNvbWUgdGhpbmdzLCBJIGFz c3VtZWQgMjQgd2FzIDI0IHBhY2tlZCBiaXRzLCBpdAo+Pj4+Pj4+PiBsb29rcwo+Pj4+Pj4+PiBs aWtlIHRoZSBkZWZhdWx0IGlzIDI0IGluIDMyIGJpdHMgc28gd2UgbWF5IGJlIG9rLiBIb3dldmVy IEkgbmVlZCB0bwo+Pj4+Pj4+PiByZS13cml0ZSBteSB0ZXN0IGNhc2Ugd2hpY2ggYXNzdW1lZCBp dCB3YXMgMjRiaXRzIGluIDMgYnl0ZXMKPj4+Pj4+Pj4gKFMyNF8zTEUpLgo+Pj4+Pj4+Pgo+Pj4+ Pj4+PiBJJ2xsIGZvbGxvdyB1cCBsYXRlciwKPj4+Pj4+Pgo+Pj4+Pj4+IE9rYXksIHRoZSBTMjRf M0xFIGlzbid0IHN1cHBvcnRlZCBieSBSVDU2NDAgY29kZWMgaW4gbXkgY2FzZS4gSQo+Pj4+Pj4+ IGJyaWVmbHkKPj4+Pj4+PiBsb29rZWQgdGhyb3VnaCB0aGUgVFJNIGRvYyBhbmQgZ290IGltcHJl c3Npb24gdGhhdCBBSFVCIGNvdWxkIHJlLXBhY2sKPj4+Pj4+PiBkYXRhIHN0cmVhbSBpbnRvIHNv bWV0aGluZyB0aGF0IGNvZGVjIHN1cHBvcnRzLCBidXQgbWF5YmUgaXQncyBhCj4+Pj4+Pj4gd3Jv bmcKPj4+Pj4+PiBpbXByZXNzaW9uLgo+Pj4+Pj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+Pj4+Pj4KPj4+Pj4+IEkgZGlkIGEgcXVpY2sgdGVzdCB3aXRoIHRoZSBmb2xsb3dp bmc6Cj4+Pj4+Pgo+Pj4+Pj4gwqDCoHNveCAtbiAtYiAxNiAtYyAyIC1yIDQ0MTAwIC90bXAvdG1w LndhdsKgIHN5bnRoIHNpbmUgNTAwIHZvbCAwLjUKPj4+Pj4+IMKgwqBzb3ggLW4gLWIgMjQgLWMg MiAtciA0NDEwMCAvdG1wL3RtcC53YXbCoCBzeW50aCBzaW5lIDUwMCB2b2wgMC41Cj4+Pj4+PiDC oMKgc294IC1uIC1iIDMyIC1jIDIgLXIgNDQxMDAgL3RtcC90bXAud2F2wqAgc3ludGggc2luZSA1 MDAgdm9sIDAuNQo+Pj4+Pj4KPj4+Pj4+IFRoZSAxNiBhbmQgMzIgd29yayBmaW5lLCB0aGUgMjQg aXMgc2hvd2luZyBhIHBsYXliYWNrIG91dHB1dCBmcmVxCj4+Pj4+PiBvZiA0NDBIeiBpbnN0ZWFk IG9mIDUwMEh6Li4uIHRoaXMgc3VnZ2VzdHMgdGhlIGNsb2NrIGlzIG9mZiwgb3IgdGhlcmUKPj4+ Pj4+IGlzIHNvbWV0aGluZyBlbHNlIHdlaXJkIGdvaW5nIG9uLi4uCj4+Pj4+Cj4+Pj4+IEkgd2Fz IGxvb2tpbmcgYXQgdXNpbmcgc294IHRvIGNyZWF0ZSBzdWNoIGFzIGZpbGUsIGJ1dCB0aGUgYWJv dmUKPj4+Pj4gY29tbWFuZAo+Pj4+PiBnZW5lcmF0ZXMgYSBTMjRfM0xFIGZpbGUgYW5kIG5vdCBT MjRfTEUgZmlsZS4gVGhlIGNvZGVjIG9uIEpldHNvbi1USzEKPj4+Pj4gc3VwcG9ydHMgUzI0X0xF IGJ1dCBkb2VzIG5vdCBzdXBwb3J0IFMyNF8zTEUgYW5kIHNvIEkgY2Fubm90IHRlc3QgdGhpcy4K Pj4+Pj4gQW55d2F5LCB3ZSByZWFsbHkgbmVlZCB0byB0ZXN0IFMyNF9MRSBhbmQgbm90IFMyNF8z TEUgYmVjYXVzZSB0aGlzIGlzCj4+Pj4+IHRoZSBwcm9ibGVtIHRoYXQgRG1pdHJ5IGlzIGhhdmlu Zy4KPj4+Pj4KPj4+Pj4gQmVuIGlzIFMyNF8zTEUgd2hhdCB5b3UgcmVhbGx5IG5lZWQgdG8gc3Vw cG9ydD8KPj4+Pj4KPj4+Pj4gRG1pdHJ5LCBkb2VzIHRoZSBmb2xsb3dpbmcgZml4IHlvdXIgcHJv YmxlbT8KPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy90ZWdyYS90ZWdyYTMwX2ky cy5jCj4+Pj4+IGIvc291bmQvc29jL3RlZ3JhL3RlZ3JhMzBfaTJzLmMKPj4+Pj4gaW5kZXggZGJl ZDNjNTQwOGU3Li45Mjg0NWM0YjYzZjQgMTAwNjQ0Cj4+Pj4+IC0tLSBhL3NvdW5kL3NvYy90ZWdy YS90ZWdyYTMwX2kycy5jCj4+Pj4+ICsrKyBiL3NvdW5kL3NvYy90ZWdyYS90ZWdyYTMwX2kycy5j Cj4+Pj4+IEBAIC0xNDAsNyArMTQwLDcgQEAgc3RhdGljIGludCB0ZWdyYTMwX2kyc19od19wYXJh bXMoc3RydWN0Cj4+Pj4+IHNuZF9wY21fc3Vic3RyZWFtICpzdWJzdHJlYW0sCj4+Pj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGF1ZGlvX2JpdHMgPSBURUdSQTMwX0FVRElPQ0lG X0JJVFNfMTY7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNhbXBsZV9z aXplID0gMTY7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+ Pj4+PiAtwqDCoMKgwqDCoMKgIGNhc2UgU05EUlZfUENNX0ZPUk1BVF9TMjRfTEU6Cj4+Pj4+ICvC oMKgwqDCoMKgwqAgY2FzZSBTTkRSVl9QQ01fRk9STUFUX1MyNF8zTEU6Cj4+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZhbCA9IFRFR1JBMzBfSTJTX0NUUkxfQklUX1NJWkVf MjQ7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGF1ZGlvX2JpdHMgPSBU RUdSQTMwX0FVRElPQ0lGX0JJVFNfMjQ7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHNhbXBsZV9zaXplID0gMjQ7Cj4+Pj4+IEBAIC0zMTgsNyArMzE4LDcgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBzbmRfc29jX2RhaV9kcml2ZXIKPj4+Pj4gdGVncmEzMF9pMnNfZGFpX3Rl bXBsYXRlID0gewo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuY2hhbm5l bHNfbWF4ID0gMiwKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLnJhdGVz ID0gU05EUlZfUENNX1JBVEVfODAwMF85NjAwMCwKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgLmZvcm1hdHMgPSBTTkRSVl9QQ01fRk1UQklUX1MzMl9MRSB8Cj4+Pj4+IC3C oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBTTkRSVl9Q Q01fRk1UQklUX1MyNF9MRSB8Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBTTkRSVl9QQ01fRk1UQklUX1MyNF8zTEUgfAo+Pj4+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgU05EUlZf UENNX0ZNVEJJVF9TMTZfTEUsCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgfSwKPj4+Pj4gwqDCoMKg wqDCoMKgwqDCoCAuY2FwdHVyZSA9IHsKPj4+Pj4gQEAgLTMyNyw3ICszMjcsNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHNuZF9zb2NfZGFpX2RyaXZlcgo+Pj4+PiB0ZWdyYTMwX2kyc19kYWlfdGVt cGxhdGUgPSB7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC5jaGFubmVs c19tYXggPSAyLAo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAucmF0ZXMg PSBTTkRSVl9QQ01fUkFURV84MDAwXzk2MDAwLAo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAuZm9ybWF0cyA9IFNORFJWX1BDTV9GTVRCSVRfUzMyX0xFIHwKPj4+Pj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFNORFJWX1BD TV9GTVRCSVRfUzI0X0xFIHwKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIFNORFJWX1BDTV9GTVRCSVRfUzI0XzNMRSB8Cj4+Pj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBTTkRSVl9Q Q01fRk1UQklUX1MxNl9MRSwKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCB9LAo+Pj4+PiDCoMKgwqDC oMKgwqDCoMKgIC5vcHMgPSAmdGVncmEzMF9pMnNfZGFpX29wcywKPj4+Pj4KPj4+Pj4gSm9uCj4+ Pj4+Cj4+Pj4KPj4+PiBJdCBzaG91bGQgc29sdmUgdGhlIHByb2JsZW0gaW4gbXkgcGFydGljdWxh ciBjYXNlLCBidXQgSSdtIG5vdCBzdXJlIHRoYXQKPj4+PiB0aGUgc29sdXRpb24gaXMgY29ycmVj dC4KPj4+Pgo+Pj4+IFRoZSB2NS41IGtlcm5lbCBpcyByZWxlYXNlZCBub3cgd2l0aCB0aGUgYnJv a2VuIGF1ZGlvIGFuZCBhcHBhcmVudGx5Cj4+Pj4gZ2V0dGluZyAyNGJpdCB0byB3b3JrIHdvbid0 IGJlIHRyaXZpYWwgKGlmIHBvc3NpYmxlIGF0IGFsbCkuIEJlbiwgY291bGQKPj4+PiB5b3UgcGxl YXNlIHNlbmQgYSBwYXRjaCB0byBmaXggdjUuNSBieSByZW1vdmluZyB0aGUgUzI0IHN1cHBvcnQK Pj4+PiBhZHZlcnRpc2VtZW50IGZyb20gdGhlIGRyaXZlcj8KPj4+Cj4+PiBJIGFsc28gc3VzcGVj dCB0aGF0IHMzMiBtYXkgbmVlZCBzb21lIGV4dHJhIHBhdGNoZXMgYW5kIHRodXMgY291bGQgYmUK Pj4+IHdvcnRod2hpbGUgdG8gc3RvcCBhZHZlcnRpc2luZyBpdCBhcyB3ZWxsLgo+Pgo+PiBBcyBm YXIgYXMgSSBhbSBhd2FyZSB0aGF0IHdvcmtzIGFuZCB3ZSBjYW4gaGl0IHRoZSBhdWRpbyByYXRl cyBmb3IgaXQuCj4gCj4gSSByYW4gYSB0ZXN0IG9uIFRlZ3JhMTI0IEpldHNvbi1USzEgYW5kIDI0 LWJpdCBwbGF5YmFjayBzZWVtcyB0byB3b3JrIGFzCj4gQmVuIGhhcyBpbmRpY2F0ZWQuIFNvIEkg ZG9uJ3QgdGhpbmsgaXQgaXMgYnJva2VuLgoKSGF2ZSB5b3UgdHJpZWQgdG8gcmVwbGljYXRlIG15 IGNhc2UgYnkgcGxheWluZyB0aGUgdmlkZW8gZmlsZT8KCj4gQ2FuIHlvdSB0cnkgQmVuJ3MgdGVz dGNhc2Ugb24gVGVncmEzMCAoaWUuIGdlbmVyYXRlIGEgdG9uZSB1c2luZyBzb3ggYW5kCj4gdXNl IGFwbGF5IHRvIHBsYXkpPwoKU3VyZWx5IEkgY2FuIHRyeSwgYnV0IG9ubHkgaWYgeW91J2xsIHNo YXJlIHRoZSBzYW1wbGUgZmlsZSB3aXRoIG1lIGFuZApnaXZlIHByZWNpc2UgaW5zdHJ1Y3Rpb25z IGhvdyB0byB0ZXN0IGl0LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5v cmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNh LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Tue, 28 Jan 2020 18:25:21 +0300 Message-ID: <4b7ccb4f-ee19-a2f2-88cb-3f0dc97f9da9@gmail.com> References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <1aa6a4bf-10ea-001d-2d35-44494d9554f8@gmail.com> <62cea895-c1f1-a833-b63c-050642bb8a79@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter , Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 28.01.2020 16:19, Jon Hunter пишет: > > On 28/01/2020 08:59, Ben Dooks wrote: >> On 27/01/2020 19:23, Dmitry Osipenko wrote: >>> 27.01.2020 22:20, Dmitry Osipenko пишет: >>>> 24.01.2020 19:50, Jon Hunter пишет: >>>>> >>>>> On 23/01/2020 19:38, Ben Dooks wrote: >>>>>> On 07/01/2020 01:39, Dmitry Osipenko wrote: >>>>>>> 06.01.2020 22:00, Ben Dooks пишет: >>>>>>>> On 05/01/2020 10:53, Ben Dooks wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2020-01-05 01:48, Dmitry Osipenko wrote: >>>>>>>>>> 05.01.2020 03:04, Ben Dooks пишет: >>>>>>>>>>> [snip] >>>>>>>>>>> >>>>>>>>>>> I've just gone through testing. >>>>>>>>>>> >>>>>>>>>>> Some simple data tests show 16 and 32-bits work. >>>>>>>>>>> >>>>>>>>>>> The 24 bit case seems to be weird, it looks like the 24-bit >>>>>>>>>>> expects >>>>>>>>>>> 24 bit samples in 32 bit words. I can't see any packing >>>>>>>>>>> options to >>>>>>>>>>> do 24 bit in 24 bit, so we may have to remove 24 bit sample >>>>>>>>>>> support >>>>>>>>>>> (which is a shame) >>>>>>>>>>> >>>>>>>>>>> My preference is to remove the 24-bit support and keep the 32 >>>>>>>>>>> bit in. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Interesting.. Jon, could you please confirm that 24bit format >>>>>>>>>> isn't >>>>>>>>>> usable on T30? >>>>>>>>> >>>>>>>>> If there is an option of 24 packed into 32, then I think that would >>>>>>>>> work. >>>>>>>>> >>>>>>>>> I can try testing that with raw data on Monday. >>>>>>>> >>>>>>>> I need to check some things, I assumed 24 was 24 packed bits, it >>>>>>>> looks >>>>>>>> like the default is 24 in 32 bits so we may be ok. However I need to >>>>>>>> re-write my test case which assumed it was 24bits in 3 bytes >>>>>>>> (S24_3LE). >>>>>>>> >>>>>>>> I'll follow up later, >>>>>>> >>>>>>> Okay, the S24_3LE isn't supported by RT5640 codec in my case. I >>>>>>> briefly >>>>>>> looked through the TRM doc and got impression that AHUB could re-pack >>>>>>> data stream into something that codec supports, but maybe it's a >>>>>>> wrong >>>>>>> impression. >>>>>>> _________________________________ >>>>>> >>>>>> I did a quick test with the following: >>>>>> >>>>>>   sox -n -b 16 -c 2 -r 44100 /tmp/tmp.wav  synth sine 500 vol 0.5 >>>>>>   sox -n -b 24 -c 2 -r 44100 /tmp/tmp.wav  synth sine 500 vol 0.5 >>>>>>   sox -n -b 32 -c 2 -r 44100 /tmp/tmp.wav  synth sine 500 vol 0.5 >>>>>> >>>>>> The 16 and 32 work fine, the 24 is showing a playback output freq >>>>>> of 440Hz instead of 500Hz... this suggests the clock is off, or there >>>>>> is something else weird going on... >>>>> >>>>> I was looking at using sox to create such as file, but the above >>>>> command >>>>> generates a S24_3LE file and not S24_LE file. The codec on Jetson-TK1 >>>>> supports S24_LE but does not support S24_3LE and so I cannot test this. >>>>> Anyway, we really need to test S24_LE and not S24_3LE because this is >>>>> the problem that Dmitry is having. >>>>> >>>>> Ben is S24_3LE what you really need to support? >>>>> >>>>> Dmitry, does the following fix your problem? >>>>> >>>>> diff --git a/sound/soc/tegra/tegra30_i2s.c >>>>> b/sound/soc/tegra/tegra30_i2s.c >>>>> index dbed3c5408e7..92845c4b63f4 100644 >>>>> --- a/sound/soc/tegra/tegra30_i2s.c >>>>> +++ b/sound/soc/tegra/tegra30_i2s.c >>>>> @@ -140,7 +140,7 @@ static int tegra30_i2s_hw_params(struct >>>>> snd_pcm_substream *substream, >>>>>                  audio_bits = TEGRA30_AUDIOCIF_BITS_16; >>>>>                  sample_size = 16; >>>>>                  break; >>>>> -       case SNDRV_PCM_FORMAT_S24_LE: >>>>> +       case SNDRV_PCM_FORMAT_S24_3LE: >>>>>                  val = TEGRA30_I2S_CTRL_BIT_SIZE_24; >>>>>                  audio_bits = TEGRA30_AUDIOCIF_BITS_24; >>>>>                  sample_size = 24; >>>>> @@ -318,7 +318,7 @@ static const struct snd_soc_dai_driver >>>>> tegra30_i2s_dai_template = { >>>>>                  .channels_max = 2, >>>>>                  .rates = SNDRV_PCM_RATE_8000_96000, >>>>>                  .formats = SNDRV_PCM_FMTBIT_S32_LE | >>>>> -                          SNDRV_PCM_FMTBIT_S24_LE | >>>>> +                          SNDRV_PCM_FMTBIT_S24_3LE | >>>>>                             SNDRV_PCM_FMTBIT_S16_LE, >>>>>          }, >>>>>          .capture = { >>>>> @@ -327,7 +327,7 @@ static const struct snd_soc_dai_driver >>>>> tegra30_i2s_dai_template = { >>>>>                  .channels_max = 2, >>>>>                  .rates = SNDRV_PCM_RATE_8000_96000, >>>>>                  .formats = SNDRV_PCM_FMTBIT_S32_LE | >>>>> -                          SNDRV_PCM_FMTBIT_S24_LE | >>>>> +                          SNDRV_PCM_FMTBIT_S24_3LE | >>>>>                             SNDRV_PCM_FMTBIT_S16_LE, >>>>>          }, >>>>>          .ops = &tegra30_i2s_dai_ops, >>>>> >>>>> Jon >>>>> >>>> >>>> It should solve the problem in my particular case, but I'm not sure that >>>> the solution is correct. >>>> >>>> The v5.5 kernel is released now with the broken audio and apparently >>>> getting 24bit to work won't be trivial (if possible at all). Ben, could >>>> you please send a patch to fix v5.5 by removing the S24 support >>>> advertisement from the driver? >>> >>> I also suspect that s32 may need some extra patches and thus could be >>> worthwhile to stop advertising it as well. >> >> As far as I am aware that works and we can hit the audio rates for it. > > I ran a test on Tegra124 Jetson-TK1 and 24-bit playback seems to work as > Ben has indicated. So I don't think it is broken. Have you tried to replicate my case by playing the video file? > Can you try Ben's testcase on Tegra30 (ie. generate a tone using sox and > use aplay to play)? Surely I can try, but only if you'll share the sample file with me and give precise instructions how to test it.