From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdOVj-0000zs-CJ for ath10k@lists.infradead.org; Fri, 13 Nov 2020 02:08:25 +0000 MIME-Version: 1.0 Date: Fri, 13 Nov 2020 10:08:13 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Arend Van Spriel Cc: Johannes Berg , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Johannes Berg , ath11k@lists.infradead.org T24gMjAyMC0xMS0xMiAyMDo0OSwgQXJlbmQgVmFuIFNwcmllbCB3cm90ZToKPiBPbiAxMS8xMi8y MDIwIDExOjU1IEFNLCBXZW4gR29uZyB3cm90ZToKPj4gT24gMjAxNy0wMy0wOCAyMToyMCwgSm9o YW5uZXMgQmVyZyB3cm90ZToKPj4+IEZyb206IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzLmJlcmdA aW50ZWwuY29tPgo+Pj4gCj4gCj4gWy4uLl0KPiAKPj4+IEBAIC0yNjg1LDYgKzI2ODYsMjEgQEAg c3RhdGljIGludCBpZWVlODAyMTFfc2V0X2JpdHJhdGVfbWFzayhzdHJ1Y3QKPj4+IHdpcGh5ICp3 aXBoeSwKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmV0Owo+Pj4gwqDCoMKg wqAgfQo+Pj4gCj4+PiArwqDCoMKgIC8qCj4+PiArwqDCoMKgwqAgKiBJZiBhY3RpdmUgdmFsaWRh dGUgdGhlIHNldHRpbmcgYW5kIHJlamVjdCBpdCBpZiBpdCBkb2Vzbid0IAo+Pj4gbGVhdmUKPj4+ ICvCoMKgwqDCoCAqIGF0IGxlYXN0IG9uZSBiYXNpYyByYXRlIHVzYWJsZSwgc2luY2Ugd2UgcmVh bGx5IGhhdmUgdG8gYmUgCj4+PiBhYmxlCj4+PiArwqDCoMKgwqAgKiB0byBzZW5kIHNvbWV0aGlu ZywgYW5kIGlmIHdlJ3JlIGFuIEFQIHdlIGhhdmUgdG8gYmUgYWJsZSB0byAKPj4+IGRvCj4+PiAr wqDCoMKgwqAgKiBzbyBhdCBhIGJhc2ljIHJhdGUgc28gdGhhdCBhbGwgY2xpZW50cyBjYW4gcmVj ZWl2ZSBpdC4KPj4+ICvCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoCBpZiAocmN1X2FjY2Vzc19wb2lu dGVyKHNkYXRhLT52aWYuY2hhbmN0eF9jb25mKSAmJgo+Pj4gK8KgwqDCoMKgwqDCoMKgIHNkYXRh LT52aWYuYnNzX2NvbmYuY2hhbmRlZi5jaGFuKSB7Cj4+PiArwqDCoMKgwqDCoMKgwqAgdTMyIGJh c2ljX3JhdGVzID0gc2RhdGEtPnZpZi5ic3NfY29uZi5iYXNpY19yYXRlczsKPj4+ICvCoMKgwqDC oMKgwqDCoCBlbnVtIG5sODAyMTFfYmFuZCBiYW5kID0gCj4+PiBzZGF0YS0+dmlmLmJzc19jb25m LmNoYW5kZWYuY2hhbi0+YmFuZDsKPj4+ICsKPj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoIShtYXNr LT5jb250cm9sW2JhbmRdLmxlZ2FjeSAmIGJhc2ljX3JhdGVzKSkKPj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiBJZiB1c2VyIHdhbnQgdG8gdXNlIOKAnGl3IHds YW4wIHNldCBiaXRyYXRlcyBsZWdhY3ktNSA1NOKAnSB0byBzZXQgaXQgdG8gCj4+IGZpeGVkIGlu IDU0TSBhbmQgNTRNIGlzCj4+IG5vdCBiYXNpYyByYXRlIGluIEFQJ3MgYmVjYW9uIGFzIGV4YW1w bGUgb2YgYmVsb3csIHRoZW4gdGhlIGl3IGNvbW1hbmQgCj4+IHdpbGwgZmFpbC4KPiAKPiBXaGlj aCB3YXMgdGhlIGludGVudCBvZiB0aGlzIGNoYW5nZSwgd2Fzbid0IGl0PyBZb3Ugd2FudCB0byBh bGxvdwo+IGFueXdheSBvciB5b3Ugd2FudCBhIGNsZWFyIGVycm9yIG1lc3NhZ2UgYXMgdG8gd2h5 IGl0IGZhaWxzPwpXZSBuZWVkIHRvIHNldCB0aGUgdHggcmF0ZSB0byBmaXhlZCBhdCBhIHNpbmds ZSByYXRlLCBlLmcuLCAKNTRNLzQ4TS8zNk0uLi4gZm9yIGEgdGVzdCBjYXNlLgpJIGRvIG5vdCB3 YW50IGEgY2xlYXIgZXJyb3IgbWVzc2FnZSwgSSB3YW50IHRvIHRoZSA1NE0gcmF0ZSBwYXNzL3Nl dCAKc3VjY2VzcyB0byBsb3dlciB3bGFuIGRyaXZlci4KVGhlbiBsb3dlciB3bGFuIGRyaXZlciBj YW4gaGFuZGxlIGl0Lgo+IAo+IFJlZ2FyZHMsCj4gQXJlbmQKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdOVk-0000zt-AP for ath11k@lists.infradead.org; Fri, 13 Nov 2020 02:08:25 +0000 MIME-Version: 1.0 Date: Fri, 13 Nov 2020 10:08:13 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Arend Van Spriel Cc: Johannes Berg , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Johannes Berg , ath11k@lists.infradead.org T24gMjAyMC0xMS0xMiAyMDo0OSwgQXJlbmQgVmFuIFNwcmllbCB3cm90ZToKPiBPbiAxMS8xMi8y MDIwIDExOjU1IEFNLCBXZW4gR29uZyB3cm90ZToKPj4gT24gMjAxNy0wMy0wOCAyMToyMCwgSm9o YW5uZXMgQmVyZyB3cm90ZToKPj4+IEZyb206IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzLmJlcmdA aW50ZWwuY29tPgo+Pj4gCj4gCj4gWy4uLl0KPiAKPj4+IEBAIC0yNjg1LDYgKzI2ODYsMjEgQEAg c3RhdGljIGludCBpZWVlODAyMTFfc2V0X2JpdHJhdGVfbWFzayhzdHJ1Y3QKPj4+IHdpcGh5ICp3 aXBoeSwKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmV0Owo+Pj4gwqDCoMKg wqAgfQo+Pj4gCj4+PiArwqDCoMKgIC8qCj4+PiArwqDCoMKgwqAgKiBJZiBhY3RpdmUgdmFsaWRh dGUgdGhlIHNldHRpbmcgYW5kIHJlamVjdCBpdCBpZiBpdCBkb2Vzbid0IAo+Pj4gbGVhdmUKPj4+ ICvCoMKgwqDCoCAqIGF0IGxlYXN0IG9uZSBiYXNpYyByYXRlIHVzYWJsZSwgc2luY2Ugd2UgcmVh bGx5IGhhdmUgdG8gYmUgCj4+PiBhYmxlCj4+PiArwqDCoMKgwqAgKiB0byBzZW5kIHNvbWV0aGlu ZywgYW5kIGlmIHdlJ3JlIGFuIEFQIHdlIGhhdmUgdG8gYmUgYWJsZSB0byAKPj4+IGRvCj4+PiAr wqDCoMKgwqAgKiBzbyBhdCBhIGJhc2ljIHJhdGUgc28gdGhhdCBhbGwgY2xpZW50cyBjYW4gcmVj ZWl2ZSBpdC4KPj4+ICvCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoCBpZiAocmN1X2FjY2Vzc19wb2lu dGVyKHNkYXRhLT52aWYuY2hhbmN0eF9jb25mKSAmJgo+Pj4gK8KgwqDCoMKgwqDCoMKgIHNkYXRh LT52aWYuYnNzX2NvbmYuY2hhbmRlZi5jaGFuKSB7Cj4+PiArwqDCoMKgwqDCoMKgwqAgdTMyIGJh c2ljX3JhdGVzID0gc2RhdGEtPnZpZi5ic3NfY29uZi5iYXNpY19yYXRlczsKPj4+ICvCoMKgwqDC oMKgwqDCoCBlbnVtIG5sODAyMTFfYmFuZCBiYW5kID0gCj4+PiBzZGF0YS0+dmlmLmJzc19jb25m LmNoYW5kZWYuY2hhbi0+YmFuZDsKPj4+ICsKPj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoIShtYXNr LT5jb250cm9sW2JhbmRdLmxlZ2FjeSAmIGJhc2ljX3JhdGVzKSkKPj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiBJZiB1c2VyIHdhbnQgdG8gdXNlIOKAnGl3IHds YW4wIHNldCBiaXRyYXRlcyBsZWdhY3ktNSA1NOKAnSB0byBzZXQgaXQgdG8gCj4+IGZpeGVkIGlu IDU0TSBhbmQgNTRNIGlzCj4+IG5vdCBiYXNpYyByYXRlIGluIEFQJ3MgYmVjYW9uIGFzIGV4YW1w bGUgb2YgYmVsb3csIHRoZW4gdGhlIGl3IGNvbW1hbmQgCj4+IHdpbGwgZmFpbC4KPiAKPiBXaGlj aCB3YXMgdGhlIGludGVudCBvZiB0aGlzIGNoYW5nZSwgd2Fzbid0IGl0PyBZb3Ugd2FudCB0byBh bGxvdwo+IGFueXdheSBvciB5b3Ugd2FudCBhIGNsZWFyIGVycm9yIG1lc3NhZ2UgYXMgdG8gd2h5 IGl0IGZhaWxzPwpXZSBuZWVkIHRvIHNldCB0aGUgdHggcmF0ZSB0byBmaXhlZCBhdCBhIHNpbmds ZSByYXRlLCBlLmcuLCAKNTRNLzQ4TS8zNk0uLi4gZm9yIGEgdGVzdCBjYXNlLgpJIGRvIG5vdCB3 YW50IGEgY2xlYXIgZXJyb3IgbWVzc2FnZSwgSSB3YW50IHRvIHRoZSA1NE0gcmF0ZSBwYXNzL3Nl dCAKc3VjY2VzcyB0byBsb3dlciB3bGFuIGRyaXZlci4KVGhlbiBsb3dlciB3bGFuIGRyaXZlciBj YW4gaGFuZGxlIGl0Lgo+IAo+IFJlZ2FyZHMsCj4gQXJlbmQKCi0tIAphdGgxMWsgbWFpbGluZyBs aXN0CmF0aDExa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vYXRoMTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85536C2D0E4 for ; Fri, 13 Nov 2020 02:08:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F288F20936 for ; Fri, 13 Nov 2020 02:08:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="kB6x1T6b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726064AbgKMCI2 (ORCPT ); Thu, 12 Nov 2020 21:08:28 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:35708 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgKMCI1 (ORCPT ); Thu, 12 Nov 2020 21:08:27 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605233307; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=pMrxmvN+z8kbW1ySQ1z021HcHfXaEdz1J1oQVNeXBh4=; b=kB6x1T6bYe5b/jwDf+QHvfrIAIIeE9YiZ4E9tpfgXhNYomsiS9hSQSE/pj2EOCeMFVugEOck RcxIItWkaWqYZ+FVbaYJntx3f0byKa4CG9L5WZ1z1HXl8LKwZ2nqwEB5g5EFV5PH3bI+bN39 RfdtNCvugNWfsBw2j5cqp22E04o= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5fadea8e3825e013b5480291 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 13 Nov 2020 02:08:14 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0B98AC433FF; Fri, 13 Nov 2020 02:08:14 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 41FF2C433C8; Fri, 13 Nov 2020 02:08:13 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 13 Nov 2020 10:08:13 +0800 From: Wen Gong To: Arend Van Spriel Cc: Johannes Berg , linux-wireless@vger.kernel.org, kirtika@google.com, Johannes Berg , linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-11-12 20:49, Arend Van Spriel wrote: > On 11/12/2020 11:55 AM, Wen Gong wrote: >> On 2017-03-08 21:20, Johannes Berg wrote: >>> From: Johannes Berg >>> > > [...] > >>> @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct >>> wiphy *wiphy, >>>              return ret; >>>      } >>> >>> +    /* >>> +     * If active validate the setting and reject it if it doesn't >>> leave >>> +     * at least one basic rate usable, since we really have to be >>> able >>> +     * to send something, and if we're an AP we have to be able to >>> do >>> +     * so at a basic rate so that all clients can receive it. >>> +     */ >>> +    if (rcu_access_pointer(sdata->vif.chanctx_conf) && >>> +        sdata->vif.bss_conf.chandef.chan) { >>> +        u32 basic_rates = sdata->vif.bss_conf.basic_rates; >>> +        enum nl80211_band band = >>> sdata->vif.bss_conf.chandef.chan->band; >>> + >>> +        if (!(mask->control[band].legacy & basic_rates)) >>> +            return -EINVAL; >> If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to >> fixed in 54M and 54M is >> not basic rate in AP's becaon as example of below, then the iw command >> will fail. > > Which was the intent of this change, wasn't it? You want to allow > anyway or you want a clear error message as to why it fails? We need to set the tx rate to fixed at a single rate, e.g., 54M/48M/36M... for a test case. I do not want a clear error message, I want to the 54M rate pass/set success to lower wlan driver. Then lower wlan driver can handle it. > > Regards, > Arend