Re: [PATCH v2] ppc/pnv: generate dtb after machine initialization is complete

[Aditya Gupta <adityag@linux.ibm.com>]

On 27/03/26 18:11, Shivang Upadhyay wrote:

> Currently, the machine dtb is generated in pnv_init(), before all devices
> are fully initialized. This can result in an incomplete dtb for the system,
> as seen in bug [1].
>
> Fix this by deferring dtb generation until machine initialization is complete,
> using the machine_init_done_notifier hook.
>
> [1] https://lore.kernel.org/all/20260323231612.GA2637687@ax162/
>
> Cc: Aditya Gupta <adityag@linux.ibm.com>
> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
> Cc: qemu-stable@nongnu.org
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: a16d4c2f162a86d ("ppc/pnv: fix dumpdtb option")
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
>
> ---
> Changes:
>
> v2:
> * moved pnv->bmc initialization to pnv_machine_init_done.
>
> v1:
> * https://lore.kernel.org/all/20260324135026.247418-1-shivangu@linux.ibm.com/
> ---
>   hw/ppc/pnv.c         | 58 +++++++++++++++++++++++++-------------------
>   include/hw/ppc/pnv.h |  2 ++
>   2 files changed, 35 insertions(+), 25 deletions(-)


Reviewed-by: Aditya Gupta <adityag@linux.ibm.com>


Thanks,

- Aditya G