From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E85BC636D6 for ; Thu, 16 Feb 2023 10:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjBPKbI convert rfc822-to-8bit (ORCPT ); Thu, 16 Feb 2023 05:31:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbjBPKbH (ORCPT ); Thu, 16 Feb 2023 05:31:07 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEEDE518ED; Thu, 16 Feb 2023 02:30:49 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A88B124E1E1; Thu, 16 Feb 2023 18:30:36 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Feb 2023 18:30:36 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Feb 2023 18:30:35 +0800 Message-ID: <4b9edac8-20bf-be1c-6b32-69b7f7616ad5@starfivetech.com> Date: Thu, 16 Feb 2023 18:30:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 4/4] dt-bindings: syscon: Add StarFive syscon doc To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Jaehoon Chung , Ulf Hansson , References: <20230215113249.47727-1-william.qiu@starfivetech.com> <20230215113249.47727-5-william.qiu@starfivetech.com> <41bcc545-6eda-6c30-c600-d97ef009abf2@linaro.org> Content-Language: en-US From: William Qiu In-Reply-To: <41bcc545-6eda-6c30-c600-d97ef009abf2@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 2023/2/16 18:23, Krzysztof Kozlowski wrote: > On 15/02/2023 12:32, William Qiu wrote: >> Add documentation to describe StarFive System Controller Registers. >> >> Signed-off-by: William Qiu >> --- > > Thank you for your patch. There is something to discuss/improve. > >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-stg-syscon >> + - starfive,jh7110-sys-syscon >> + - starfive,jh7110-aon-syscon > > Maybe keep them ordered alphabetically? > I'm sorting by register address, or I can keep them ordered alphabetically，which is better? >> + - const: syscon >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + syscon@10240000 { >> + compatible = "starfive,jh7110-stg-syscon", "syscon"; >> + reg = <0x10240000 0x1000>; >> + }; > > Keep only one example. All others are the same. > Will update in next version. Thanks for taking times to review this patch series. Best regards William > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF051C61DA4 for ; Thu, 16 Feb 2023 10:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gb8goFWB7a/zRfSAWJL92uzbu/Expn/e3CjZLoUy83I=; b=4XigPb6y8ZKq4d Yu/fRL8QZtXcbcRfnrNGgUSdaowGy5ICJNd3wBmSRMoEhefPFT3sORRXghwiWhgrP3Pr4/hPJv9wL OSydPzZmbAgqPsTLsdPvEtGNcXP//pGPEF16t4gG+jMsy2JoVbQ9WZzCtd+xUqgbMQTlPfLwu0nHa /Uh84hACqQQafKpD8z+6L5WRjc1j+ik4Xvp9BfD5yyoKRXqmfZ172kcP4NMGhclb/g/fp7xjB4duw aTxFqo4jmJnyEo9Q8ogyaKe6IDuMn2k53/nfPAbfpl/nRwYEQjEW4bGXjXb11nd+cqtHm+eNlGwGv U+Oj/PU0MNWhHnUupLxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSbXh-009ZhG-7q; Thu, 16 Feb 2023 10:31:09 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSbXa-009Ze9-T0 for linux-riscv@lists.infradead.org; Thu, 16 Feb 2023 10:31:07 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A88B124E1E1; Thu, 16 Feb 2023 18:30:36 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Feb 2023 18:30:36 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Feb 2023 18:30:35 +0800 Message-ID: <4b9edac8-20bf-be1c-6b32-69b7f7616ad5@starfivetech.com> Date: Thu, 16 Feb 2023 18:30:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 4/4] dt-bindings: syscon: Add StarFive syscon doc To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Jaehoon Chung , Ulf Hansson , References: <20230215113249.47727-1-william.qiu@starfivetech.com> <20230215113249.47727-5-william.qiu@starfivetech.com> <41bcc545-6eda-6c30-c600-d97ef009abf2@linaro.org> Content-Language: en-US From: William Qiu In-Reply-To: <41bcc545-6eda-6c30-c600-d97ef009abf2@linaro.org> X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_023103_234428_52E71399 X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIzLzIvMTYgMTg6MjMsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4gT24gMTUv MDIvMjAyMyAxMjozMiwgV2lsbGlhbSBRaXUgd3JvdGU6Cj4+IEFkZCBkb2N1bWVudGF0aW9uIHRv IGRlc2NyaWJlIFN0YXJGaXZlIFN5c3RlbSBDb250cm9sbGVyIFJlZ2lzdGVycy4KPj4gCj4+IFNp Z25lZC1vZmYtYnk6IFdpbGxpYW0gUWl1IDx3aWxsaWFtLnFpdUBzdGFyZml2ZXRlY2guY29tPgo+ PiAtLS0KPiAKPiBUaGFuayB5b3UgZm9yIHlvdXIgcGF0Y2guIFRoZXJlIGlzIHNvbWV0aGluZyB0 byBkaXNjdXNzL2ltcHJvdmUuCj4gCj4+ICtwcm9wZXJ0aWVzOgo+PiArICBjb21wYXRpYmxlOgo+ PiArICAgIGl0ZW1zOgo+PiArICAgICAgLSBlbnVtOgo+PiArICAgICAgICAgIC0gc3RhcmZpdmUs amg3MTEwLXN0Zy1zeXNjb24KPj4gKyAgICAgICAgICAtIHN0YXJmaXZlLGpoNzExMC1zeXMtc3lz Y29uCj4+ICsgICAgICAgICAgLSBzdGFyZml2ZSxqaDcxMTAtYW9uLXN5c2Nvbgo+IAo+IE1heWJl IGtlZXAgdGhlbSBvcmRlcmVkIGFscGhhYmV0aWNhbGx5Pwo+IAoKSSdtIHNvcnRpbmcgYnkgcmVn aXN0ZXIgYWRkcmVzcywgb3IgSSBjYW4ga2VlcCB0aGVtIG9yZGVyZWQKYWxwaGFiZXRpY2FsbHnv vIx3aGljaCBpcyBiZXR0ZXI/Cj4+ICsgICAgICAtIGNvbnN0OiBzeXNjb24KPj4gKwo+PiArICBy ZWc6Cj4+ICsgICAgbWF4SXRlbXM6IDEKPj4gKwo+PiArcmVxdWlyZWQ6Cj4+ICsgIC0gY29tcGF0 aWJsZQo+PiArICAtIHJlZwo+PiArCj4+ICthZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UKPj4g Kwo+PiArZXhhbXBsZXM6Cj4+ICsgIC0gfAo+PiArICAgIHN5c2NvbkAxMDI0MDAwMCB7Cj4+ICsg ICAgICAgIGNvbXBhdGlibGUgPSAic3RhcmZpdmUsamg3MTEwLXN0Zy1zeXNjb24iLCAic3lzY29u IjsKPj4gKyAgICAgICAgcmVnID0gPDB4MTAyNDAwMDAgMHgxMDAwPjsKPj4gKyAgICB9Owo+IAo+ IEtlZXAgb25seSBvbmUgZXhhbXBsZS4gQWxsIG90aGVycyBhcmUgdGhlIHNhbWUuCj4gCldpbGwg dXBkYXRlIGluIG5leHQgdmVyc2lvbi4KVGhhbmtzIGZvciB0YWtpbmcgdGltZXMgdG8gcmV2aWV3 IHRoaXMgcGF0Y2ggc2VyaWVzLgoKQmVzdCByZWdhcmRzCldpbGxpYW0KPiAKPiBCZXN0IHJlZ2Fy ZHMsCj4gS3J6eXN6dG9mCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJpc2N2Cg==